Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise minimum python version to 3.8 and drop typing_extensions #357

Merged
merged 1 commit into from Aug 24, 2023

Conversation

nekopsykose
Copy link
Contributor

typing.Literal was in python 3.8, so there isn't a need for this dependency on anything newer

@nekopsykose
Copy link
Contributor Author

ah, mypy requires the specific Literal for itself..

@nekopsykose
Copy link
Contributor Author

explicit seems to work instead

@davidhewitt
Copy link
Member

Given that setuptools now requires 3.8, I'd also be ok with doing the same here to simplify things.

@nekopsykose
Copy link
Contributor Author

hm, that also works. sure

@nekopsykose nekopsykose changed the title only use typing_extensions for older python versions raise minimum python version to 3.8 and drop typing_extensions Aug 23, 2023
@davidhewitt
Copy link
Member

Thanks, looks like two final things needed here please:

  • Remove 3.7 jobs from .github/workflows/ci.yml.
  • Add a Packaging entry to the CHANGELOG (e.g. see release notes for 1.2 where we dropped 3.6 support).

@nekopsykose
Copy link
Contributor Author

good catch, thanks :)

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks 👍

@davidhewitt davidhewitt merged commit 8da3512 into PyO3:main Aug 24, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants