Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move IntoPy::type_output to IntoPyObject::type_output #4657

Merged
merged 3 commits into from
Oct 26, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Oct 26, 2024

Part of #4618

This moves IntoPy::type_output to IntoPyObject::type_output. This is a breaking change, but this is an experimantel feature and the ergonomics of duplicating the API is pretty bad, because it would need fully qualified syntax on the callsite to determine the trait to use.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
@Icxolu
Copy link
Contributor Author

Icxolu commented Oct 26, 2024

Not really sure why MSRV needs the additional lifetime bounds, but they should be implied anyway, so spelling them out should not really be a problem either.

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this is fine to do in my opinion. Weird about those inferred lifetimes, I guess we live with them for now.

@davidhewitt davidhewitt added this pull request to the merge queue Oct 26, 2024
Merged via the queue into PyO3:main with commit f536ece Oct 26, 2024
43 of 44 checks passed
@Icxolu Icxolu deleted the move-type-output branch October 26, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants