Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added abi3-py312 feature #3687

Merged
merged 1 commit into from Dec 21, 2023
Merged

added abi3-py312 feature #3687

merged 1 commit into from Dec 21, 2023

Conversation

alex
Copy link
Contributor

@alex alex commented Dec 21, 2023 •
edited by adamreichold

Fixes #3645

@adamreichold adamreichold changed the title Fixes #3645 -- added abi3-py312 feature added abi3-py312 feature Dec 21, 2023
adamreichold
adamreichold reviewed Dec 21, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
adamreichold
adamreichold reviewed Dec 21, 2023
View reviewed changes
pyo3-ffi/Cargo.toml Outdated Show resolved Hide resolved
@alex
Copy link
Contributor Author

alex commented Dec 21, 2023

Doh, good catch.

davidhewitt
davidhewitt approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!👍

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 21, 2023 •
edited

CodSpeed Performance Report

Merging #3687 will improve performances by 22.03%

Comparing alex:abi3-py312 (d92792f) with main (2788f4a)

Summary

⚡ 1 improvements
✅ 77 untouched benchmarks

Benchmarks breakdown

Benchmark main alex:abi3-py312 Change
⚡ not_a_list_via_downcast 153.9 ns 126.1 ns +22.03%

@adamreichold adamreichold added this pull request to the merge queue Dec 21, 2023
Merged via the queue into PyO3:main with commit 1fa47b0 Dec 21, 2023
37 checks passed
@alex alex deleted the abi3-py312 branch December 21, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamreichold adamreichold adamreichold left review comments

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please add an abi3-py312 feature flag
3 participants
@alex @davidhewitt @adamreichold