Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update definitions for objimpl.h #3403

Merged
merged 1 commit into from Aug 19, 2023
Merged

update definitions for objimpl.h #3403

merged 1 commit into from Aug 19, 2023

Conversation

davidhewitt
Copy link
Member

@davidhewitt davidhewitt commented Aug 18, 2023 •
edited

While looking into #3064 I noticed that our definitions for objimpl.h were extremely out of date. (I wanted to use the added symbols for debugging purposes.)

Mostly this is just reshuffling, the API changes are in the newsfragments.

davidhewitt
davidhewitt commented Aug 19, 2023
View reviewed changes
Copy link
Member Author

@davidhewitt davidhewitt left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a mechanical update to these FFI definitions with nothing I'd expect to be contentious, I'm going to save on reviewer bandwidth and just merge this.

@davidhewitt davidhewitt added this pull request to the merge queue Aug 19, 2023
Merged via the queue into PyO3:main with commit 9336e5b Aug 19, 2023
31 of 32 checks passed
@davidhewitt davidhewitt deleted the ffi-objimpl branch August 19, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@davidhewitt