Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to syn 2 #3239

Merged
merged 1 commit into from Jun 14, 2023
Merged

Upgrade to syn 2 #3239

merged 1 commit into from Jun 14, 2023

Conversation

alex
Copy link
Contributor

@alex alex commented Jun 13, 2023 •
edited

fixes #3113

davidhewitt
davidhewitt reviewed Jun 14, 2023
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a much appreciated tidy-up! Just a couple of small suggestions.

newsfragments/3239.changed.md Outdated Show resolved Hide resolved
pyo3-macros-backend/src/attributes.rs Outdated Show resolved Hide resolved
@alex
Copy link
Contributor Author

alex commented Jun 14, 2023

Done!

davidhewitt
davidhewitt approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@davidhewitt davidhewitt added this pull request to the merge queue Jun 14, 2023
Merged via the queue into PyO3:main with commit 527f3c2 Jun 14, 2023
31 of 32 checks passed
@alex alex deleted the syn-2 branch June 14, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

syn 2.0 and MSRV
2 participants
@alex @davidhewitt