remove all functionality deprecated in PyO3 0.18 #3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
remove-0-18-deprecations
branch
from
13e6005
to
beb4dde
Compare
|
Looks like this also removes the usage of |
adamreichold
approved these changes
Jun 13, 2023
|
I think what I'll do is split this out into separate PRs with separate changelog items, and merge them in turn given the approvals here. |
|
Actually I've changed my mind; I'll just update the CHANGELOG entry and also add a small migration guide entry. |
davidhewitt
force-pushed
the
remove-0-18-deprecations
branch
from
beb4dde
to
4f3fcdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned out to be a very satisfying purge of complexity, mostly due to removing the backwards-compatibility for
#[pyfunction(a, b)]and#[args(a, b)]which have been replaced by#[pyo3(signature = (a, b))].