Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional tests for #3168 #3175

Closed

Conversation

lifthrasiir
Copy link
Contributor

These were a part of tests I was preparing for #3165, and I believe it's worthy to add them (any single of them fails in the current main branch).

@messense messense added the CI-skip-changelog Skip checking changelog entry label May 22, 2023
@adamreichold
Copy link
Member

any single of them fails in the current main branch

I am confused now: They do seem to pass in the CI? Do they fail only intermittently? Could you also check whether #3168 does resolve the issues you found?

@lifthrasiir
Copy link
Contributor Author

lifthrasiir commented May 22, 2023

Sorry, your PR definitely passes all of those tests (as confirmed by the CI). I meant to say that those tests are crafted so that PyO3 don't pass them without your PR.

@adamreichold
Copy link
Member

Ah sorry, I missed the target branch of this PR! It is targetting #3168 and not main.

Also sorry for not starting with that: Thank you for going the extra mile and packaging up your tests so we can include them upstream!

@DataTriny
Copy link
Contributor

DataTriny commented May 22, 2023

First time contributor has agreed to the new licensing scheme.

@adamreichold adamreichold mentioned this pull request May 23, 2023
7 tasks
Copy link
Member

@adamreichold adamreichold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this comprehensive set of tests.

I'll hold off merging this into #3168 until we have consensus that that approach is what we will pursue to avoid that this PR needs to be recreated if we decide to pursue another approach.

@adamreichold adamreichold force-pushed the no-gil-in-traverse branch 3 times, most recently from 89a6c43 to 08bdc32 Compare May 25, 2023 18:03
@bors bors bot deleted the branch PyO3:no-gil-in-traverse May 25, 2023 19:21
@bors bors bot closed this May 25, 2023
@lifthrasiir lifthrasiir deleted the no-gil-in-traverse branch May 26, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants