Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Simplify version handling of UI tests. #3171

Merged
merged 6 commits into from
May 25, 2023
Merged

RFC: Simplify version handling of UI tests. #3171

merged 6 commits into from
May 25, 2023

Commits on May 25, 2023

  1. Simplify version handling of UI tests. 

    Due to checking in error outputs these tests only work reliably on stable and
not on intermediate version between our MSRV (currently 1.48) and the current
stable version.

Hence this simplifies things to run only MSRV-compatible tests for the MSRV
builds, anything else for stable builds except for those tests which require the
nightly feature, i.e. the `Ungil` being distinct from the `Send` trait.

Finally, `not_send3` is disabled when using the nightly feature since while `Rc`
is not send, it also not GIL-bound and hence can be passed into `allow_threads`
as it does not actually spawn a new thread.
    @adamreichold
    adamreichold committed May 25, 2023
    Configuration menu
    Copy the full SHA
    426e189 View commit details
    Browse the repository at this point in the history

  2. Also ignore error outputs on MSRV to further simplify UI tests.

    @adamreichold
    adamreichold committed May 25, 2023
    Configuration menu
    Copy the full SHA
    8b14797 View commit details
    Browse the repository at this point in the history

  3. Remove compiler UI tests from package distribution since they only wo… 

    …rk reliably using the current stable version Rust, e.g. in our CI.
    @adamreichold
    adamreichold committed May 25, 2023
    Configuration menu
    Copy the full SHA
    c34870c View commit details
    Browse the repository at this point in the history

  4. Replace the nightly UI tests by doctests since we cannot keep up with… 

    … the changing error outputs of nightly in any case.
    @adamreichold
    adamreichold committed May 25, 2023
    Configuration menu
    Copy the full SHA
    90fcc63 View commit details
    Browse the repository at this point in the history

  5. Manually link to the send_wrapper crate to avoid having it as a build… 

    … dependencies for the docs.
    @adamreichold
    adamreichold committed May 25, 2023
    Configuration menu
    Copy the full SHA
    4fc7b5a View commit details
    Browse the repository at this point in the history

  6. Be more explicit of the soundness hole implied by tying Ungil to Send… 

    … and mention the available solution.
    @adamreichold
    adamreichold committed May 25, 2023
    Configuration menu
    Copy the full SHA
    0f628c9 View commit details
    Browse the repository at this point in the history