Add support for #[new] which is also a #[classmethod]
#3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
force-pushed
the
stuhood/classmethod-new
branch
3 times, most recently
from
329ef94
to
756d150
Compare
|
First time contributor has agreed to the new licensing scheme. |
stuhood
force-pushed
the
stuhood/classmethod-new
branch
from
756d150
to
716de0b
Compare
stuhood
force-pushed
the
stuhood/classmethod-new
branch
from
716de0b
to
6c3fd07
Compare
davidhewitt
reviewed
May 16, 2023
There was a problem hiding this comment.
Thanks! The implementation is fine; I'm not a huge fan of a new enum variant in FnType though I can't see an obviously better way to do it. I think better to deliver the working feature and then hopefully over time refactoring will present an option.
Some suggestions for docs & tests.
stuhood
force-pushed
the
stuhood/classmethod-new
branch
from
8818b2f
to
55a217f
Compare
|
Thanks! Have applied that feedback. |
davidhewitt
approved these changes
May 16, 2023
stuhood
force-pushed
the
stuhood/classmethod-new
branch
from
55a217f
to
20c5618
Compare
adamreichold
approved these changes
May 17, 2023
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors bot
added a commit
that referenced
this pull request
May 29, 2023
3188: Verify that macros do work without any imports r=adamreichold a=lifthrasiir Currently virtually all (positive) tests import `pyo3::prelude::*`, making it hard to detect a certain class of bugs. This PR adds an explicit test that never imports from `pyo3` to fix this. Also this fixes a minor bug from #3157 which didn't work without `use pyo3::types::PyType;`. I think this should be a part of 0.19.0 (#3187), so no additional changelog would be required (as this feature is new in 0.19.0). Co-authored-by: Kang Seonghoon <public+git@mearie.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3077.