Unwrap dynamic error types when inner is simple PyErr

[BlueGlassBlock]

This is the first part of suggested improvements in #2998.

This change will make bubbled PyErr wrapped in eyre::Report / anyhow::Error bubble up unchanged, instead of being wrapped in a PyRuntimeError.

[adamreichold]

Thanks! I think this is a nice improvement with minimal effort.

[adamreichold]

@mejrs Will wait for your feedback before merging as you sounded unsure whether this is a sensible thing to do in the issue.

[davidhewitt]

While I think this change is strictly an improvement, I'd like to quickly take a moment to think about how we document this and / or provide backwards compatibility.

Changing the error type observed here may catch some users out. Probably module docs need updating. Should this go in the migration guide?

[DataTriny]

First time contributor has agreed to the new licensing scheme.

[mejrs]

@mejrs Will wait for your feedback before merging as you sounded unsure whether this is a sensible thing to do in the issue.

I have nothing, feel free to merge as you wish :)

[adamreichold]

@BlueGlassBlock You would be up to writing an entry for the migration guide showing the difference when forwarding errors using anyhow or eyre? The module docs definitely must be changed to match the proposed implementation.

[BlueGlassBlock]

@BlueGlassBlock You would be up to writing an entry for the migration guide showing the difference when forwarding errors using anyhow or eyre? The module docs definitely must be changed to match the proposed implementation.

Certainly!

[adamreichold]

Thanks for drafting the migration guide entry. Please remember to adjust the existing module-level docs in anyhow.rs and eyre.rs which currently still state that a RuntimeError is produced unconditionally.

[adamreichold]

Changing the error type observed here may catch some users out. Probably module docs need updating. Should this go in the migration guide?

@davidhewitt I think this better positioned now w.r.t. the above concerns and therefore ready to be merged. Do you agree?

[davidhewitt]

Yep this looks great to me now, thanks! I'll squash and merge this now.

[davidhewitt]

bors r=davidhewitt,adamreichold,mejrs

[bors]

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

• conclusion