Use a full path for #[new] method which is also #[classmethod].

PyO3 · May 29, 2023 · b0ef56b · b0ef56b
1 parent 34d9af8
commit b0ef56b
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/pyo3-macros-backend/src/method.rs b/pyo3-macros-backend/src/method.rs
@@ -506,7 +506,9 @@ impl<'a> FnSpec<'a> {
                 let (arg_convert, args) = impl_arg_params(self, cls, &py, false)?;
                 let call = match &self.tp {
                     FnType::FnNew => quote! { #rust_name(#(#args),*) },
-                    FnType::FnNewClass => quote! { #rust_name(PyType::from_type_ptr(#py, subtype), #(#args),*) },
+                    FnType::FnNewClass => {
+                        quote! { #rust_name(_pyo3::types::PyType::from_type_ptr(#py, subtype), #(#args),*) }
+                    }
                     x => panic!("Only `FnNew` or `FnNewClass` may use the `TpNew` calling convention. Got: {:?}", x),
                 };
                 quote! {

diff --git a/tests/test_no_imports.rs b/tests/test_no_imports.rs
@@ -121,3 +121,26 @@ fn test_basic() {
         pyo3::py_run!(py, *d, "b += a; assert (b.v, b.s) == (19, 'foobar!')");
     });
 }
+
+#[pyo3::pyclass]
+struct NewClassMethod {
+    #[pyo3(get)]
+    cls: pyo3::PyObject,
+}
+
+#[pyo3::pymethods]
+impl NewClassMethod {
+    #[new]
+    #[classmethod]
+    fn new(cls: &pyo3::types::PyType) -> Self {
+        Self { cls: cls.into() }
+    }
+}
+
+#[test]
+fn test_new_class_method() {
+    pyo3::Python::with_gil(|py| {
+        let cls = py.get_type::<NewClassMethod>();
+        pyo3::py_run!(py, cls, "assert cls().cls is cls");
+    });
+}