Add runner attributes to WorkflowJob #2902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2902 +/- ##
=======================================
Coverage 96.70% 96.71%
=======================================
Files 147 147
Lines 14885 14913 +28
=======================================
+ Hits 14395 14423 +28
Misses 490 490 ☔ View full report in Codecov by Sentry. |
boomanaiden154
force-pushed
the
add-runner-attributes-workflow-job
branch
from
76cd136
to
f5a4b81
Compare
This patch adds the runner attributes to the WorkflowJob class. The four attributes, runner_id, runner_name, runner_group_id, and runner_group_name are always sent along with the job information, but before this patch, are not represented in PyGtithub. This patch adds the attributes and test coverage.
boomanaiden154
force-pushed
the
add-runner-attributes-workflow-job
branch
from
f5a4b81
to
3b0ef28
Compare
EnricoMi
requested changes
Feb 22, 2024
EnricoMi
requested changes
Mar 14, 2024
Comment on lines
+56
to
+59
| self._runner_id: Attribute[int] = NotSet | ||
| self._runner_name: Attribute[str] = NotSet | ||
| self._runner_group_id: Attribute[int] = NotSet | ||
| self._runner_group_name: Attribute[str] = NotSet |
There was a problem hiding this comment.
Can you keep this list of attributes in alphabetical order?
|
Looks like I did this review before... what a pity... |
To speed things up, I opened a PR #2921 with @boomanaiden154 changes and addressed your feedback @EnricoMi |
|
Superseded by #2921. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the runner attributes to the WorkflowJob class. The four attributes, runner_id, runner_name, runner_group_id, and runner_group_name are always sent along with the job information, but before this patch, are not represented in PyGtithub. This patch adds the attributes and test coverage.