Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manage require_last_push_approval and allow_deletions in branch protection #2716

Closed
wants to merge 6 commits into from

Conversation

terenho
Copy link
Contributor

@terenho terenho commented Aug 12, 2023

fixes #2360

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e584a90) 96.74% compared to head (8911903) 96.73%.
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2716      +/-   ##
==========================================
- Coverage   96.74%   96.73%   -0.01%     
==========================================
  Files         139      139              
  Lines       14184    14214      +30     
==========================================
+ Hits        13722    13750      +28     
- Misses        462      464       +2     
Files Coverage Δ
github/BranchProtection.py 91.89% <100.00%> (+0.84%) ⬆️
github/GithubRetry.py 93.81% <100.00%> (ø)
github/RepositoryAdvisory.py 93.39% <ø> (ø)
github/RequiredPullRequestReviews.py 96.77% <100.00%> (+0.41%) ⬆️
github/Auth.py 95.73% <75.00%> (-0.38%) ⬇️
github/Branch.py 88.88% <93.33%> (+0.33%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@terenho terenho force-pushed the last_push_approval branch 2 times, most recently from 82d98c4 to 17a1a18 Compare August 12, 2023 00:53
@terenho terenho changed the title manage require_last_push_approval branch protection feat: manage require_last_push_approval branch protection Aug 12, 2023
Copy link
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have tests for the new fields?

github/Branch.py Outdated Show resolved Hide resolved
github/BranchProtection.py Show resolved Hide resolved
@terenho terenho marked this pull request as draft August 23, 2023 23:04
@terenho terenho force-pushed the last_push_approval branch 14 times, most recently from ffc42cf to 6badde8 Compare August 24, 2023 07:26
@terenho terenho changed the title feat: manage require_last_push_approval branch protection feat: manage require_last_push_approval and allow_deletions in branch protection Aug 24, 2023
@terenho
Copy link
Contributor Author

terenho commented Aug 24, 2023

Can we have tests for the new fields?

Added/updated tests for the new fields in the latest commits

@terenho terenho marked this pull request as ready for review August 24, 2023 07:34
@terenho
Copy link
Contributor Author

terenho commented Oct 13, 2023

@EnricoMi I have added the allow_deletion function and added tests, I also resolved a merge conflict. This PR is ready for review.

@EnricoMi
Copy link
Collaborator

Superseded by #2873, added you as co-author to appreciate your contribution.

@EnricoMi EnricoMi closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request. Support require_last_push_approval
3 participants