Add missing params to `Organization.create_repo` #2700

tekumara · 2023-07-26T12:50:59Z

Adds missing params to Organization.create_repo, to match the Repository class updates added in #2742.

Fixes #2403 .

codecov-commenter · 2023-07-26T12:54:02Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c589bf9) 96.69% compared to head (e1f1e69) 96.69%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2700   +/-   ##
=======================================
  Coverage   96.69%   96.69%           
=======================================
  Files         142      142           
  Lines       14524    14532    +8     
=======================================
+ Hits        14044    14052    +8     
  Misses        480      480

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

EnricoMi · 2023-09-04T07:33:13Z

Hi @tekumara, the Repository class has been updated in #2742, would you like to update the Organization.create_repo accordingly? There are a few more attributes to add.

tekumara · 2023-09-10T02:28:06Z

Hi @EnricoMi I've updated Organization please take a look.

EnricoMi · 2023-09-12T10:29:38Z

Excellent, thanks! The pyi file ahs just been merged into py, and some related code has changed. Can you please rebase with latest master or redo on top of current master?

tekumara · 2023-09-12T11:49:45Z

👍 how does it look now @EnricoMi ?

EnricoMi

Can we have tests for the new fields?

github/Organization.py

Co-authored-by: Enrico Minack <github@enrico.minack.dev>

tekumara · 2023-09-13T02:03:50Z

thanks for the suggestions, they've been applied

tekumara · 2023-10-01T04:22:40Z

The mypy failures look unrelated to this change:

Error: github/GithubRetry.py:79:16: error: Incompatible return value type (got "Retry", expected "Self")  [return-value]
Error: github/GithubRetry.py:85:9: error: Argument 3 of "increment" is incompatible with supertype "Retry"; supertype defines the argument type as "Optional[BaseHTTPResponse]"  [override]
github/GithubRetry.py:85:9: note: This violates the Liskov substitution principle
github/GithubRetry.py:85:9: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
Found 2 errors in 1 file (checked 265 source files)
Error: Process completed with exit code 1.

zamberjo · 2023-10-18T06:45:07Z

Hi, could you make the changes also for the edit endpoint?

PyGithub/github/Repository.py

Line 1841 in dc37d5c

use_squash_pr_title_as_default: Opt[bool] = NotSet,

This reverts commit f4c9a83.

tekumara · 2023-10-18T09:22:16Z

Hi @zamberjo can you elaborate on what changes you are expecting here to Repository.edit?

PyGithub/github/Repository.py

Line 1841 in dc37d5c

use_squash_pr_title_as_default: Opt[bool] = NotSet,

I can see Repository.edit already has use_squash_pr_title_as_default, and the other params I'm adding in this PR to Organization.create_repo. So it's not clear to me what you'd like to see.

zamberjo · 2023-10-18T09:43:39Z

Sorry, I think I was looking at an earlier version.

LGTM

github/Organization.py

Co-authored-by: Enrico Minack <github@enrico.minack.dev>

github/Organization.py

EnricoMi

LGTM!

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [PyGithub](https://togithub.com/pygithub/pygithub) | `==2.1.1` -> `==2.2.0` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/PyGithub/2.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/PyGithub/2.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/PyGithub/2.1.1/2.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/PyGithub/2.1.1/2.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pygithub/pygithub (PyGithub)</summary> ### [`v2.2.0`](https://togithub.com/PyGithub/PyGithub/releases/tag/v2.2.0) [Compare Source](https://togithub.com/pygithub/pygithub/compare/v2.1.1...v2.2.0) #### Breaking Changes The `github.Comparison.Comparison` instance returned by `Repository.compare` provides a `commits` property that used to return a `list[github.Commit.Commit]`, which has now been changed to `PaginatedList[github.Commit.Commit]`. This breaks user code that assumes a `list`: ```python commits = repo.compare("v0.6", "v0.7").commits no_of_commits = len(commits) # will raise a TypeError ``` This will raise a `TypeError: object of type 'PaginatedList' has no len()`, as the returned `PaginatedList` does not support the `len()` method. Use the `totalCount` property instead: ```python commits = repo.compare("v0.6", "v0.7").commits no_of_commits = commits.totalCount ``` #### New features - Add support to call GraphQL API #### Improvements - Add parent_team_id, maintainers and notification_setting for creating and updating teams. by [@Cheshirez](https://togithub.com/Cheshirez) in [PyGithub/PyGithub#2863 - Add support for issue reactions summary by [@smuzaffar](https://togithub.com/smuzaffar) in [PyGithub/PyGithub#2866 - Support for DependabotAlert APIs by [@coopernetes](https://togithub.com/coopernetes) in [PyGithub/PyGithub#2879 - Derive GraphQL URL from base_url by [@EnricoMi](https://togithub.com/EnricoMi) in [PyGithub/PyGithub#2880 - Make `Repository.compare().commits` return paginated list by [@EnricoMi](https://togithub.com/EnricoMi) in [PyGithub/PyGithub#2882 - Add missing branch protection fields by [@treee111](https://togithub.com/treee111) in [PyGithub/PyGithub#2873 - Add `include_all_branches` to `create_repo_from_template` of `AuthenticatedUser` and `Organization` by [@janssonoskar](https://togithub.com/janssonoskar) in [PyGithub/PyGithub#2871 - Add and update organisation dependabot secrets by [@mohy01](https://togithub.com/mohy01) in [PyGithub/PyGithub#2316 - Add missing params to `Organization.create_repo` by [@tekumara](https://togithub.com/tekumara) in [PyGithub/PyGithub#2700 - Update allowed values for `Repository` collaborator permissions by [@flying-sheep](https://togithub.com/flying-sheep) in [PyGithub/PyGithub#1996 - Support editing PullRequestReview by [@ColasGael](https://togithub.com/ColasGael) in [PyGithub/PyGithub#2851 - Update attributes after calling `PullRequestReview.dismiss` by [@ColasGael](https://togithub.com/ColasGael) in [PyGithub/PyGithub#2854 - Add `request_cve` on `RepositoryAdvisories` by [@JLLeitschuh](https://togithub.com/JLLeitschuh) in [PyGithub/PyGithub#2855 - Filter collaborators of a repository by permissions by [@notmicaelfilipe](https://togithub.com/notmicaelfilipe) in [PyGithub/PyGithub#2792 - Set pull request to auto merge via GraphQL API by [@heitorpolidoro](https://togithub.com/heitorpolidoro) in [PyGithub/PyGithub#2816 - Support Environment Variables and Secrets by [@AndrewJDawes](https://togithub.com/AndrewJDawes) in [PyGithub/PyGithub#2848 - Update workflow.get_runs & pullrequest.add_to_assignees function signature by [@sd-kialo](https://togithub.com/sd-kialo) in [PyGithub/PyGithub#2799 - Add `GithubObject.last_modified_datetime` to have `last_modified` as a `datetime` by [@chouetz](https://togithub.com/chouetz) in [PyGithub/PyGithub#2772 - Add support for global advisories and unify some shared logic with repository advisories by [@crimsonknave](https://togithub.com/crimsonknave) in [PyGithub/PyGithub#2702 - Add `internal` as valid Repository visibility value by [@AndrewJDawes](https://togithub.com/AndrewJDawes) in [PyGithub/PyGithub#2806 - Add support for issue comments reactions summary by [@smuzaffar](https://togithub.com/smuzaffar) in [PyGithub/PyGithub#2813 #### Bug Fixes - Add a bunch of missing urllib.parse.quote calls by [@ExplodingCabbage](https://togithub.com/ExplodingCabbage) in [PyGithub/PyGithub#1976 - Fix Variable and Secret url bugs by [@AndrewJDawes](https://togithub.com/AndrewJDawes) in [PyGithub/PyGithub#2835 #### Maintenance - Update the class name for NetrcAuth in the examples by [@vinnybod](https://togithub.com/vinnybod) in [PyGithub/PyGithub#2860 - Move build to PEP517 by [@trim21](https://togithub.com/trim21) in [PyGithub/PyGithub#2800 - Use new type assert functions in `Repository` by [@trim21](https://togithub.com/trim21) in [PyGithub/PyGithub#2798 - PyTest: Move config to pyproject.toml by [@Borda](https://togithub.com/Borda) in [PyGithub/PyGithub#2859 - codespell: ignore-words-list by [@Borda](https://togithub.com/Borda) in [PyGithub/PyGithub#2858 - Improve fix-headers.py script by [@EnricoMi](https://togithub.com/EnricoMi) in [PyGithub/PyGithub#2728 - Remove dependency on python-dateutil by [@lazka](https://togithub.com/lazka) in [PyGithub/PyGithub#2804 - CI: update precommit & apply by [@Borda](https://togithub.com/Borda) in [PyGithub/PyGithub#2600 - Docs: Fix parameter order according to Version 2.1.0 by [@nad182](https://togithub.com/nad182) in [PyGithub/PyGithub#2786 - Add missing GitHub classes to docs by [@EnricoMi](https://togithub.com/EnricoMi) in [PyGithub/PyGithub#2783 - CI: Fix mypy error by ignoring override by [@EnricoMi](https://togithub.com/EnricoMi) in [PyGithub/PyGithub#2779 **Full Changelog**: PyGithub/PyGithub@v2.1.1...v2.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/lettuce-financial/github-bot-signed-commit).

tekumara added 2 commits July 26, 2023 22:44

add squash_merge_commit_*

70e0583

.

143eb86

tekumara mentioned this pull request Jul 29, 2023

Missing new options for controlling the default commit title on the Repository #2403

Closed

tekumara added 2 commits September 10, 2023 12:15

Merge remote-tracking branch 'upstream/main'

d98509e

add merge_commit_* too to match Repository.py

edf7d02

tekumara changed the title ~~feat: add squash_merge_commit_* to Repository~~ feat: add commit title and message params to Organization.create_repo Sep 10, 2023

Merge branch 'main' of github.com:PyGithub/PyGithub

dc1a675

EnricoMi requested changes Sep 12, 2023

View reviewed changes

github/Organization.py Outdated Show resolved Hide resolved

github/Organization.py Outdated Show resolved Hide resolved

tekumara and others added 2 commits September 13, 2023 12:02

Update github/Organization.py

4015c5c

Co-authored-by: Enrico Minack <github@enrico.minack.dev>

Update Organization.py

2009e3b

tekumara added 4 commits September 26, 2023 23:21

Merge branch 'main' into main

a4c4591

Merge remote-tracking branch 'upstream/main'

5e220b2

Merge branch 'main' of https://github.com/tekumara/PyGithub

cd0d0f9

black

14cffe8

tekumara added 3 commits October 18, 2023 20:03

Merge branch 'main' into main

8380095

update edit method too

f4c9a83

Revert "update edit method too"

643521e

This reverts commit f4c9a83.

zamberjo approved these changes Oct 18, 2023

View reviewed changes

Merge branch 'main' into main

9e9bc3c

EnricoMi requested changes Dec 22, 2023

View reviewed changes

github/Organization.py Outdated Show resolved Hide resolved

github/Organization.py Show resolved Hide resolved

EnricoMi changed the title ~~feat: add commit title and message params to Organization.create_repo~~ Add missing params to Organization.create_repo Dec 22, 2023

tekumara and others added 4 commits December 22, 2023 20:59

Update github/Organization.py

de17f55

Co-authored-by: Enrico Minack <github@enrico.minack.dev>

Update github/Organization.py

464955f

Co-authored-by: Enrico Minack <github@enrico.minack.dev>

simplify

6bacf13

additional properties

742f219

EnricoMi requested changes Dec 22, 2023

View reviewed changes

github/Organization.py Outdated Show resolved Hide resolved

Fix assertion typo

e1f1e69

EnricoMi approved these changes Dec 22, 2023

View reviewed changes

EnricoMi merged commit 9c61a2a into PyGithub:main Dec 22, 2023
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing params to `Organization.create_repo` #2700

Add missing params to `Organization.create_repo` #2700

tekumara commented Jul 26, 2023 •

edited by EnricoMi

codecov-commenter commented Jul 26, 2023 •

edited

EnricoMi commented Sep 4, 2023

tekumara commented Sep 10, 2023

EnricoMi commented Sep 12, 2023

tekumara commented Sep 12, 2023

EnricoMi left a comment

tekumara commented Sep 13, 2023

tekumara commented Oct 1, 2023

zamberjo commented Oct 18, 2023

tekumara commented Oct 18, 2023

zamberjo commented Oct 18, 2023

EnricoMi left a comment

Add missing params to Organization.create_repo #2700

Add missing params to Organization.create_repo #2700

Conversation

tekumara commented Jul 26, 2023 • edited by EnricoMi

codecov-commenter commented Jul 26, 2023 • edited

Codecov Report

EnricoMi commented Sep 4, 2023

tekumara commented Sep 10, 2023

EnricoMi commented Sep 12, 2023

tekumara commented Sep 12, 2023

EnricoMi left a comment

Choose a reason for hiding this comment

tekumara commented Sep 13, 2023

tekumara commented Oct 1, 2023

zamberjo commented Oct 18, 2023

tekumara commented Oct 18, 2023

zamberjo commented Oct 18, 2023

EnricoMi left a comment

Choose a reason for hiding this comment

Add missing params to `Organization.create_repo` #2700

Add missing params to `Organization.create_repo` #2700

tekumara commented Jul 26, 2023 •

edited by EnricoMi

codecov-commenter commented Jul 26, 2023 •

edited