Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github/MainClass: Fix GitHubException instantiation #2079

Closed
wants to merge 2 commits into from

Conversation

CyberShadow
Copy link

@CyberShadow CyberShadow commented Oct 15, 2021

The mandatory "headers" argument was not being supplied.

Attempts to fix e.g.:

...
  File "/home/runner/actions-runner/_work/repo/repo/venv/lib64/python3.9/site-packages/github/MainClass.py", line 862, in get_access_token
    raise GithubException.GithubException(
TypeError: __init__() missing 1 required positional argument: 'headers'

Not sure how to test this; hope this helps nevertheless.

The mandatory "headers" argument was not being supplied.
@atodorov
Copy link

atodorov commented Jan 5, 2022

@s-t-e-v-e-n-k this seems like a serious problem. Can you merge this PR and possibly build a new version for PyPI ?

atodorov added a commit to kiwitcms/github-app that referenced this pull request Jan 5, 2022
atodorov added a commit to kiwitcms/github-app that referenced this pull request Jan 5, 2022
atodorov added a commit to kiwitcms/github-app that referenced this pull request Jan 5, 2022
Copy link
Contributor

@treee111 treee111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small formatting thingy

github/MainClass.py Show resolved Hide resolved
@atodorov
Copy link

ping. Any news here? It looks like this PR is ready to be merged.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@stale stale bot closed this Apr 28, 2022
@CyberShadow
Copy link
Author

???

@CyberShadow
Copy link
Author

@s-t-e-v-e-n-k @xmo-odoo If contributions / pull requests are not welcome in this project could you please clarify this in the project documentation so we don't waste our time in the future, thank you.

@xmo-odoo
Copy link
Contributor

I've no idea, I just contributed a few PRs (and at least one of mine got closed by stalebot recently: #2120, #2122).

I think stevenk is just busy with stuff, that happens.

@CyberShadow
Copy link
Author

Sorry @xmo-odoo, you're right, I misread the commit history and thought you were a committer.
@s-t-e-v-e-n-k Please don't use stale bots, they do more harm than good. Not just in terms of value they bring to the particular project, but they generally erode public trust and willingness to participate in open-source software development.
See the discussions here: https://www.google.com/search?q=stale+bot+site%3Aycombinator.com

@EnricoMi
Copy link
Collaborator

EnricoMi commented Jun 7, 2023

Looks like this has been fixed when #1986 moved to using the Requester, which implements those exceptions correctly.

@EnricoMi
Copy link
Collaborator

Already fixed by #1986.

@EnricoMi EnricoMi closed this Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants