Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support full GitHub app authentication #1986

Merged
merged 35 commits into from
Feb 6, 2023
Merged

Support full GitHub app authentication #1986

merged 35 commits into from
Feb 6, 2023

Commits on Jun 30, 2021

  1. Support full GitHub app authentication

    @dblanchette
    dblanchette committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    885a522 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2021

  1. Fix main class type

    @dblanchette
    dblanchette committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    a719746 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2021

  1. Merge master and fix conflict

    @dblanchette
    dblanchette committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    c39a183 View commit details
    Browse the repository at this point in the history

  2. Remove unused imports

    @dblanchette
    dblanchette committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    d8b20e1 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. Merge branch 'master' into feature/github-app-authentication

    @dblanchette
    dblanchette committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    30a11a0 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Code review changes

    @dblanchette
    dblanchette committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    c15de72 View commit details
    Browse the repository at this point in the history

  2. Fix type annotation

    @dblanchette
    dblanchette committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    f8a071b View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. Remove default values in type hints

    @dblanchette
    dblanchette committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    e957467 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2022

  1. Remove default values in .pyi (again)

    @dblanchette
    dblanchette committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    add6683 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into feature/github-app-… 

    …authentication
    @dblanchette
    dblanchette committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    3ba6e76 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Merge branch 'master' into feature/github-app-authentication

    @dblanchette
    dblanchette committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    8df28e9 View commit details
    Browse the repository at this point in the history

  2. black

    @dblanchette
    dblanchette committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    a461e0e View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. Refactor GithubIntegration class and add test case for app authentica… 

    …tion

Add permissions and repository properties in InstallationAuthorization
Set JWT_EXPIRY=60 by default in GithubIntegration constructor
    @ammarmallik
    ammarmallik committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    94ca7be View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. Modify existing testcases for GithubIntegration as per the framework … 

    …and add missing tests
    @ammarmallik
    ammarmallik committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    8e47431 View commit details
    Browse the repository at this point in the history

  2. Provide installation ID for creating the access token instead of gett… 

    …ing the first installation
    @ammarmallik
    ammarmallik committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    a9c2f81 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Add test case for getting app installation

    @ammarmallik
    ammarmallik committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    b88f36f View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. Add optional permissions support for installation access token

    @ammarmallik
    ammarmallik committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    8534fe9 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Merge pull request #28 from ammarmallik/feature/github-app-authentica… 

    …tion

* Calls to get User/Repo/Org installation
* Require installation ID to use app authentication
* Support scopes (permissions) for app authentication
* JWT expiration now configurable
    @dblanchette
    dblanchette committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    d502f27 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feature/github-app-authentication

    @dblanchette
    dblanchette committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    350911e View commit details
    Browse the repository at this point in the history

  3. flake8 not on gitlab anymore?

    @dblanchette
    dblanchette committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    15f1c0c View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Merge branch 'master' into feature/github-app-authentication

    @dblanchette
    dblanchette committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    99e6b3a View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2023

  1. Add lock around app authentication

    @dblanchette
    dblanchette committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    ceb8d7d View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. Remove unrelated fixes

    @dblanchette
    dblanchette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    df38766 View commit details
    Browse the repository at this point in the history

  2. A tab

    @dblanchette
    dblanchette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    8899a9e View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. Keep compatibility for importing GithubIntegration from MainClass 

    Fix a type and a docstring
    @dblanchette
    dblanchette committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    38fb3cd View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Group app authentication parameters in a class

    @dblanchette
    dblanchette committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    2c106c6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feature/github-app-authentication

    @dblanchette
    dblanchette committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    ce199bf View commit details
    Browse the repository at this point in the history

  3. Remove useless exception handling

    @dblanchette
    dblanchette committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    a50aecd View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Add isinstance checks in github/AppAuthentication.py 

    Co-authored-by: Enrico Minack <github@enrico.minack.dev>
    @dblanchette @EnricoMi
    dblanchette and EnricoMi committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    0e245d0 View commit details
    Browse the repository at this point in the history

  2. Code review changes

    @dblanchette
    dblanchette committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    7d61945 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'coveord/feature/github-app-authenticati… 

    …on' into feature/github-app-authentication
    @dblanchette
    dblanchette committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    a7ca0cb View commit details
    Browse the repository at this point in the history

  4. Fix an assert

    @dblanchette
    dblanchette committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    7dd9fa9 View commit details
    Browse the repository at this point in the history

  5. black

    @dblanchette
    dblanchette committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    7e6d5b7 View commit details
    Browse the repository at this point in the history

  6. Remove useless check

    @dblanchette
    dblanchette committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    148c14f View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Fix an assert and a docstring

    @dblanchette
    dblanchette committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    3e16166 View commit details
    Browse the repository at this point in the history