Add a bunch of missing urllib.parse.quote calls

github/AuthenticatedUser.py

@@ -40,6 +40,7 @@
 ################################################################################
 from __future__ import annotations
 
+import urllib.parse
 from datetime import datetime, timezone
 from typing import TYPE_CHECKING, Any, NamedTuple
 
@@ -810,6 +811,7 @@ def get_repo(self, name: str) -> Repository:
         :calls: `GET /repos/{owner}/{repo} <http://docs.github.com/en/rest/reference/repos>`_
         """
         assert isinstance(name, str), name
+        name = urllib.parse.quote(name)
         headers, data = self._requester.requestJsonAndCheck("GET", f"/repos/{self.login}/{name}")
         return github.Repository.Repository(self._requester, headers, data, completed=True)
 
@@ -1032,6 +1034,7 @@ def get_organization_membership(self, org: str) -> Membership:
         :calls: `GET /user/memberships/orgs/{org} <https://docs.github.com/en/rest/reference/orgs#get-an-organization-membership-for-the-authenticated-user>`_
         """
         assert isinstance(org, str)
+        org = urllib.parse.quote(org)
         headers, data = self._requester.requestJsonAndCheck("GET", f"/user/memberships/orgs/{org}")
         return github.Membership.Membership(self._requester, headers, data, completed=True)
 

github/Enterprise.py

@@ -19,6 +19,7 @@
 # along with PyGithub. If not, see <http://www.gnu.org/licenses/>.             #
 #                                                                              #
 ################################################################################
+import urllib.parse
 from typing import Any, Dict
 
 from github.EnterpriseConsumedLicenses import EnterpriseConsumedLicenses
@@ -37,6 +38,7 @@ def __init__(
         requester: Requester,
         enterprise: str,
     ):
+        enterprise = urllib.parse.quote(enterprise)
         super().__init__(requester, {}, {"enterprise": enterprise, "url": f"/enterprises/{enterprise}"}, True)
 
     def _initAttributes(self) -> None:

github/GithubIntegration.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import urllib.parse
 import warnings
 from typing import Any
 
@@ -216,6 +217,8 @@ def get_installation(self, owner: str, repo: str) -> Installation:
 
         :calls: `GET /repos/{owner}/{repo}/installation <https://docs.github.com/en/rest/reference/apps#get-a-repository-installation-for-the-authenticated-app>`
         """
+        owner = urllib.parse.quote(owner)
+        repo = urllib.parse.quote(repo)
         return self._get_installed_app(url=f"/repos/{owner}/{repo}/installation")
 
     def get_installations(self) -> PaginatedList[Installation]:
@@ -235,18 +238,22 @@ def get_org_installation(self, org: str) -> Installation:
         """
         :calls: `GET /orgs/{org}/installation <https://docs.github.com/en/rest/apps/apps#get-an-organization-installation-for-the-authenticated-app>`
         """
+        org = urllib.parse.quote(org)
         return self._get_installed_app(url=f"/orgs/{org}/installation")
 
     def get_repo_installation(self, owner: str, repo: str) -> Installation:
         """
         :calls: `GET /repos/{owner}/{repo}/installation <https://docs.github.com/en/rest/reference/apps#get-a-repository-installation-for-the-authenticated-app>`
         """
+        owner = urllib.parse.quote(owner)
+        repo = urllib.parse.quote(repo)
         return self._get_installed_app(url=f"/repos/{owner}/{repo}/installation")
 
     def get_user_installation(self, username: str) -> Installation:
         """
         :calls: `GET /users/{username}/installation <https://docs.github.com/en/rest/apps/apps#get-a-user-installation-for-the-authenticated-app>`
         """
+        username = urllib.parse.quote(username)
         return self._get_installed_app(url=f"/users/{username}/installation")
 
     def get_app_installation(self, installation_id: int) -> Installation:

github/MainClass.py

@@ -84,6 +84,7 @@
 from __future__ import annotations
 
 import pickle
+import urllib.parse
 import warnings
 from datetime import datetime
 from typing import TYPE_CHECKING, Any, BinaryIO, TypeVar
@@ -321,6 +322,7 @@ def get_license(self, key: Opt[str] = NotSet) -> License:
         """
 
         assert isinstance(key, str), key
+        key = urllib.parse.quote(key)
         headers, data = self.__requester.requestJsonAndCheck("GET", f"/licenses/{key}")
         return github.License.License(self.__requester, headers, data, completed=True)
 
@@ -344,10 +346,11 @@ def get_user(self, login: Opt[str] = NotSet) -> NamedUser | AuthenticatedUser:
         """
         :calls: `GET /users/{user} <https://docs.github.com/en/rest/reference/users>`_ or `GET /user <https://docs.github.com/en/rest/reference/users>`_
         """
-        assert login is NotSet or isinstance(login, str), login
         if login is NotSet:
             return github.AuthenticatedUser.AuthenticatedUser(self.__requester, {}, {"url": "/user"}, completed=False)
         else:
+            assert isinstance(login, str), login
+            login = urllib.parse.quote(login)
             headers, data = self.__requester.requestJsonAndCheck("GET", f"/users/{login}")
             return github.NamedUser.NamedUser(self.__requester, headers, data, completed=True)
 
@@ -376,6 +379,7 @@ def get_organization(self, login: str) -> Organization:
         :calls: `GET /orgs/{org} <https://docs.github.com/en/rest/reference/orgs>`_
         """
         assert isinstance(login, str), login
+        login = urllib.parse.quote(login)
         headers, data = self.__requester.requestJsonAndCheck("GET", f"/orgs/{login}")
         return github.Organization.Organization(self.__requester, headers, data, completed=True)
 
@@ -487,6 +491,7 @@ def get_global_advisory(self, ghsa_id: str) -> GlobalAdvisory:
         :rtype: :class:`github.GlobalAdvisory.GlobalAdvisory`
         """
         assert isinstance(ghsa_id, str), ghsa_id
+        ghsa_id = urllib.parse.quote(ghsa_id)
         headers, data = self.__requester.requestJsonAndCheck("GET", f"/advisories/{ghsa_id}")
         return github.GlobalAdvisory.GlobalAdvisory(self.__requester, headers, data, completed=True)
 
@@ -847,6 +852,7 @@ def get_hook(self, name: str) -> HookDescription:
         :calls: `GET /hooks/{name} <https://docs.github.com/en/rest/reference/repos#webhooks>`_
         """
         assert isinstance(name, str), name
+        name = urllib.parse.quote(name)
         headers, attributes = self.__requester.requestJsonAndCheck("GET", f"/hooks/{name}")
         return HookDescription(self.__requester, headers, attributes, completed=True)
 
@@ -892,6 +898,7 @@ def get_gitignore_template(self, name: str) -> GitignoreTemplate:
         :calls: `GET /gitignore/templates/{name} <https://docs.github.com/en/rest/reference/gitignore>`_
         """
         assert isinstance(name, str), name
+        name = urllib.parse.quote(name)
         headers, attributes = self.__requester.requestJsonAndCheck("GET", f"/gitignore/templates/{name}")
         return github.GitignoreTemplate.GitignoreTemplate(self.__requester, headers, attributes, completed=True)
 
@@ -953,7 +960,6 @@ def get_app(self, slug: Opt[str] = NotSet) -> GithubApp:
         """
         :calls: `GET /apps/{slug} <https://docs.github.com/en/rest/reference/apps>`_ or `GET /app <https://docs.github.com/en/rest/reference/apps>`_
         """
-        assert slug is NotSet or isinstance(slug, str), slug
 
         if slug is NotSet:
             # with no slug given, calling /app returns the authenticated app,
@@ -965,5 +971,7 @@ def get_app(self, slug: Opt[str] = NotSet) -> GithubApp:
             )
             return GithubIntegration(**self.__requester.kwargs).get_app()
         else:
+            assert isinstance(slug, str), slug
             # with a slug given, we can lazily load the GithubApp
+            slug = urllib.parse.quote(slug)
             return github.GithubApp.GithubApp(self.__requester, {}, {"url": f"/apps/{slug}"}, completed=False)

github/Migration.py

@@ -31,6 +31,7 @@
 ################################################################################
 from __future__ import annotations
 
+import urllib.parse
 from datetime import datetime
 from typing import Any
 
@@ -145,6 +146,7 @@ def unlock_repo(self, repo_name: str) -> None:
         :calls: `DELETE /user/migrations/{migration_id}/repos/{repo_name}/lock <https://docs.github.com/en/rest/reference/migrations>`_
         """
         assert isinstance(repo_name, str), repo_name
+        repo_name = urllib.parse.quote(repo_name)
         headers, data = self._requester.requestJsonAndCheck(
             "DELETE",
             f"{self.url}/repos/{repo_name}/lock",

github/NamedUser.py

@@ -36,6 +36,7 @@
 ################################################################################
 from __future__ import annotations
 
+import urllib.parse
 from datetime import datetime
 from typing import TYPE_CHECKING, Any
 
@@ -514,6 +515,7 @@ def get_organization_membership(self, org: str | Organization) -> Membership:
         assert isinstance(org, str) or isinstance(org, github.Organization.Organization), org
         if isinstance(org, github.Organization.Organization):
             org = org.login  # type: ignore
+        org = urllib.parse.quote(org)
         headers, data = self._requester.requestJsonAndCheck("GET", f"/orgs/{org}/memberships/{self.login}")
         return github.Membership.Membership(self._requester, headers, data, completed=True)
 

github/Organization.py

@@ -41,6 +41,7 @@
 ################################################################################
 from __future__ import annotations
 
+import urllib.parse
 from datetime import datetime
 from typing import TYPE_CHECKING, Any
 
@@ -527,16 +528,18 @@ def create_secret(
         if is_defined(selected_repositories):
             put_parameters["selected_repository_ids"] = [element.id for element in selected_repositories]
 
-        self._requester.requestJsonAndCheck("PUT", f"{self.url}/actions/secrets/{secret_name}", input=put_parameters)
+        self._requester.requestJsonAndCheck(
+            "PUT", f"{self.url}/actions/secrets/{urllib.parse.quote(secret_name)}", input=put_parameters
+        )
 
         return github.OrganizationSecret.OrganizationSecret(
             requester=self._requester,
             headers={},
             attributes={
                 "name": secret_name,
                 "visibility": visibility,
-                "selected_repositories_url": f"{self.url}/actions/secrets/{secret_name}/repositories",
-                "url": f"{self.url}/actions/secrets/{secret_name}",
+                "selected_repositories_url": f"{self.url}/actions/secrets/{urllib.parse.quote(secret_name)}/repositories",
+                "url": f"{self.url}/actions/secrets/{urllib.parse.quote(secret_name)}",
             },
             completed=False,
         )
@@ -564,7 +567,7 @@ def get_secret(self, secret_name: str) -> OrganizationSecret:
         return github.OrganizationSecret.OrganizationSecret(
             requester=self._requester,
             headers={},
-            attributes={"url": f"{self.url}/actions/secrets/{secret_name}"},
+            attributes={"url": f"{self.url}/actions/secrets/{urllib.parse.quote(secret_name)}"},
             completed=False,
         )
 
@@ -640,7 +643,7 @@ def create_variable(
                 "name": variable_name,
                 "visibility": visibility,
                 "value": value,
-                "selected_repositories_url": f"{self.url}/actions/variables/{variable_name}/repositories",
+                "selected_repositories_url": f"{self.url}/actions/variables/{urllib.parse.quote(variable_name)}/repositories",
                 "url": self.url,
             },
             completed=False,
@@ -669,7 +672,7 @@ def get_variable(self, variable_name: str) -> OrganizationVariable:
         return github.OrganizationVariable.OrganizationVariable(
             requester=self._requester,
             headers={},
-            attributes={"url": f"{self.url}/actions/variables/{variable_name}"},
+            attributes={"url": f"{self.url}/actions/variables/{urllib.parse.quote(variable_name)}"},
             completed=False,
         )
 
@@ -922,6 +925,7 @@ def get_repo(self, name: str) -> Repository:
         :rtype: :class:`github.Repository.Repository`
         """
         assert isinstance(name, str), name
+        name = urllib.parse.quote(name)
         headers, data = self._requester.requestJsonAndCheck(
             "GET",
             f"/repos/{self.login}/{name}",
@@ -968,6 +972,7 @@ def get_team_by_slug(self, slug: str) -> Team:
         :calls: `GET /orgs/{org}/teams/{team_slug} <https://docs.github.com/en/rest/reference/teams#get-a-team-by-name>`_
         """
         assert isinstance(slug, str), slug
+        slug = urllib.parse.quote(slug)
         headers, data = self._requester.requestJsonAndCheck("GET", f"{self.url}/teams/{slug}")
         return github.Team.Team(self._requester, headers, data, completed=True)