Review Comments: Removing redundant ReplayData and unneeded self. ref…

…erences in tests
PyGithub · Feb 8, 2024 · 88704cf · 88704cf
1 parent 4573b2e
commit 88704cf
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 52 deletions.
diff --git a/tests/Organization.py b/tests/Organization.py
@@ -580,26 +580,26 @@ def testCreateActionsSecret(self, encrypt):
 
     @mock.patch("github.PublicKey.encrypt")
     def testCreateDependabotSecret(self, encrypt):
-        self.org = self.g.get_organization("demoorg")
+        org = self.g.get_organization("demoorg")
         # encrypt returns a non-deterministic value, we need to mock it so the replay data matches
         encrypt.return_value = "M+5Fm/BqTfB90h3nC7F3BoZuu3nXs+/KtpXwxm9gG211tbRo0F5UiN0OIfYT83CKcx9oKES9Va4E96/b"
-        secret = self.org.create_secret("secret_name", "secret-value", secret_type="dependabot", visibility="all")
+        secret = org.create_secret("secret_name", "secret-value", secret_type="dependabot", visibility="all")
         self.assertIsNotNone(secret)
 
     def testOrgGetSecretAssertion(self):
-        self.org = self.g.get_organization("demoorg")
+        org = self.g.get_organization("demoorg")
         try:
-            self.org.get_secret(secret_name="splat", secret_type="supersecret")
+            org.get_secret(secret_name="splat", secret_type="supersecret")
         except AssertionError:
             assert True
 
     @mock.patch("github.PublicKey.encrypt")
     def testCreateDependabotSecretSelected(self, encrypt):
-        self.org = self.g.get_organization("demoorg")
-        repos = [self.org.get_repo("demo-repo-1"), self.org.get_repo("demo-repo-2")]
+        org = self.g.get_organization("demoorg")
+        repos = [org.get_repo("demo-repo-1"), org.get_repo("demo-repo-2")]
         # encrypt returns a non-deterministic value, we need to mock it so the replay data matches
         encrypt.return_value = "M+5Fm/BqTfB90h3nC7F3BoZuu3nXs+/KtpXwxm9gG211tbRo0F5UiN0OIfYT83CKcx9oKES9Va4E96/b"
-        secret = self.org.create_secret(
+        secret = org.create_secret(
             secret_name="SECRET_DEP_NAME",
             unencrypted_value="secret-value",
             visibility="selected",
@@ -613,11 +613,11 @@ def testCreateDependabotSecretSelected(self, encrypt):
 
     @mock.patch("github.PublicKey.encrypt")
     def testOrgSecretEdit(self, encrypt):
-        self.org = self.g.get_organization("demoorg")
-        repos = [self.org.get_repo("demo-repo-1"), self.org.get_repo("demo-repo-2")]
+        org = self.g.get_organization("demoorg")
+        repos = [org.get_repo("demo-repo-1"), org.get_repo("demo-repo-2")]
         # encrypt returns a non-deterministic value, we need to mock it so the replay data matches
         encrypt.return_value = "M+5Fm/BqTfB90h3nC7F3BoZuu3nXs+/KtpXwxm9gG211tbRo0F5UiN0OIfYT83CKcx9oKES9Va4E96/b"
-        secret = self.org.create_secret(
+        secret = org.create_secret(
             secret_name="secret_act_name",
             unencrypted_value="secret-value",
             visibility="selected",

diff --git a/tests/ReplayData/Organization.testCreateSecret.txt b/tests/ReplayData/Organization.testCreateSecret.txt
diff --git a/tests/ReplayData/Repository.testCreateSecret.txt b/tests/ReplayData/Repository.testCreateSecret.txt