Skip to content

Commit

Permalink
address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
thomascrowley committed Jan 31, 2024
1 parent 820fd48 commit 2cb9dc1
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
Expand Up @@ -101,6 +101,8 @@ Also note that if you record your test data with `--auth_with_token` then you al
```python
def setUp(self):
self.tokenAuthMode = True
super().setUp()
...
```

A simple alternative is to replace `token private_token_removed` with `Basic login_and_password_removed` in all your newly generated ReplayData files.
Expand Down
1 change: 1 addition & 0 deletions github/Organization.py
Expand Up @@ -1023,6 +1023,7 @@ def convert_to_outside_collaborator(self, member: NamedUser) -> None:
def get_public_key(self, secret_type: str = "actions") -> PublicKey:
"""
:calls: `GET /orgs/{org}/{secret_type}/secrets/public-key <https://docs.github.com/en/rest/reference/actions#get-an-organization-public-key>`_
:param secret_type: string options actions or dependabot
:rtype: :class:`github.PublicKey.PublicKey`
"""
headers, data = self._requester.requestJsonAndCheck("GET", f"{self.url}/{secret_type}/secrets/public-key")
Expand Down
1 change: 1 addition & 0 deletions github/OrganizationSecret.py
Expand Up @@ -73,6 +73,7 @@ def edit(
:param variable_name: string
:param value: string
:param visibility: string
:param secret_type: string options actions or dependabot
:rtype: bool
"""
assert isinstance(value, str), value
Expand Down
1 change: 1 addition & 0 deletions github/Repository.py
Expand Up @@ -3009,6 +3009,7 @@ def get_network_events(self) -> PaginatedList[Event]:
def get_public_key(self, secret_type: str = "actions") -> PublicKey:
"""
:calls: `GET /repos/{owner}/{repo}/actions/secrets/public-key <https://docs.github.com/en/rest/reference/actions#get-a-repository-public-key>`_
:param secret_type: string options actions or dependabot
:rtype: :class:`github.PublicKey.PublicKey`
"""
assert secret_type in ["actions", "dependabot"], "secret_type should be actions or dependabot"
Expand Down

0 comments on commit 2cb9dc1

Please sign in to comment.