Make delivered_at a datetime attribute

PyGithub · Jun 20, 2023 · 16ffa39 · 16ffa39
1 parent 2b2177a
commit 16ffa39
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 10 deletions.
diff --git a/github/HookDelivery.py b/github/HookDelivery.py
@@ -27,6 +27,7 @@
 # along with PyGithub. If not, see <http://www.gnu.org/licenses/>.             #
 #                                                                              #
 ################################################################################
+from datetime import datetime
 from typing import Any, Dict, Optional
 
 import github.GithubObject
@@ -56,9 +57,9 @@ def guid(self) -> Optional[str]:
         return self._guid.value
 
     @property
-    def delivered_at(self) -> Optional[str]:
+    def delivered_at(self) -> Optional[datetime]:
         """
-        :type: string
+        :type: datetime
         """
         return self._delivered_at.value
 
@@ -128,7 +129,7 @@ def url(self) -> Optional[str]:
     def _initAttributes(self) -> None:
         self._id: Attribute[int] = NotSet
         self._guid: Attribute[str] = NotSet
-        self._delivered_at: Attribute[int] = NotSet
+        self._delivered_at: Attribute[datetime] = NotSet
         self._redelivery: Attribute[bool] = NotSet
         self._duration: Attribute[float] = NotSet
         self._status: Attribute[str] = NotSet
@@ -145,7 +146,7 @@ def _useAttributes(self, attributes: Dict[str, Any]):
         if "guid" in attributes:  # pragma no branch
             self._guid = self._makeStringAttribute(attributes["guid"])
         if "delivered_at" in attributes:  # pragma no branch
-            self._delivered_at = self._makeStringAttribute(attributes["delivered_at"])
+            self._delivered_at = self._makeDatetimeAttribute(attributes["delivered_at"])
         if "redelivery" in attributes:  # pragma no branch
             self._redelivery = self._makeBoolAttribute(attributes["redelivery"])
         if "duration" in attributes:  # pragma no branch

diff --git a/tests/Github_.py b/tests/Github_.py
@@ -208,7 +208,7 @@ def testGetHookDelivery(self):
         delivery = self.g.get_hook_delivery(257993, 12345)
         self.assertEqual(delivery.id, 12345)
         self.assertEqual(delivery.guid, "abcde-12345")
-        self.assertEqual(delivery.delivered_at, "2012-05-27T06:00:32Z")
+        self.assertEqual(delivery.delivered_at, datetime.datetime(2012, 5, 27, 6, 0, 32))
         self.assertEqual(delivery.redelivery, False)
         self.assertEqual(delivery.duration, 0.27)
         self.assertEqual(delivery.status, "OK")
@@ -234,7 +234,7 @@ def testGetHookDeliveries(self):
         self.assertEqual(len(deliveries), 1)
         self.assertEqual(deliveries[0].id, 12345)
         self.assertEqual(deliveries[0].guid, "abcde-12345")
-        self.assertEqual(deliveries[0].delivered_at, "2012-05-27T06:00:32Z")
+        self.assertEqual(deliveries[0].delivered_at, datetime.datetime(2012, 5, 27, 6, 0, 32))
         self.assertEqual(deliveries[0].redelivery, False)
         self.assertEqual(deliveries[0].duration, 0.27)
         self.assertEqual(deliveries[0].status, "OK")

diff --git a/tests/Organization.py b/tests/Organization.py
@@ -189,7 +189,7 @@ def testGetHookDelivery(self):
         delivery = self.org.get_hook_delivery(257993, 12345)
         self.assertEqual(delivery.id, 12345)
         self.assertEqual(delivery.guid, "abcde-12345")
-        self.assertEqual(delivery.delivered_at, "2012-05-27T06:00:32Z")
+        self.assertEqual(delivery.delivered_at, datetime.datetime(2012, 5, 27, 6, 0, 32))
         self.assertEqual(delivery.redelivery, False)
         self.assertEqual(delivery.duration, 0.27)
         self.assertEqual(delivery.status, "OK")
@@ -215,7 +215,7 @@ def testGetHookDeliveries(self):
         self.assertEqual(len(deliveries), 1)
         self.assertEqual(deliveries[0].id, 12345)
         self.assertEqual(deliveries[0].guid, "abcde-12345")
-        self.assertEqual(deliveries[0].delivered_at, "2012-05-27T06:00:32Z")
+        self.assertEqual(deliveries[0].delivered_at, datetime.datetime(2012, 5, 27, 6, 0, 32))
         self.assertEqual(deliveries[0].redelivery, False)
         self.assertEqual(deliveries[0].duration, 0.27)
         self.assertEqual(deliveries[0].status, "OK")

diff --git a/tests/Repository.py b/tests/Repository.py
@@ -939,7 +939,7 @@ def testGetHookDelivery(self):
         delivery = self.repo.get_hook_delivery(257993, 12345)
         self.assertEqual(delivery.id, 12345)
         self.assertEqual(delivery.guid, "abcde-12345")
-        self.assertEqual(delivery.delivered_at, "2012-05-27T06:00:32Z")
+        self.assertEqual(delivery.delivered_at, datetime.datetime(2012, 5, 27, 6, 0, 32))
         self.assertEqual(delivery.redelivery, False)
         self.assertEqual(delivery.duration, 0.27)
         self.assertEqual(delivery.status, "OK")
@@ -965,7 +965,7 @@ def testGetHookDeliveries(self):
         self.assertEqual(len(deliveries), 1)
         self.assertEqual(deliveries[0].id, 12345)
         self.assertEqual(deliveries[0].guid, "abcde-12345")
-        self.assertEqual(deliveries[0].delivered_at, "2012-05-27T06:00:32Z")
+        self.assertEqual(deliveries[0].delivered_at, datetime.datetime(2012, 5, 27, 6, 0, 32))
         self.assertEqual(deliveries[0].redelivery, False)
         self.assertEqual(deliveries[0].duration, 0.27)
         self.assertEqual(deliveries[0].status, "OK")