Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not cache configuration files #1995

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Do not cache configuration files #1995

merged 2 commits into from
Feb 10, 2023

Commits on Feb 8, 2023

  1. Do not cache configuration files 

    Fixes PyCQA#1994

isort can run in long processes when used in an editor.  In that
scenario it is confusing for users when editing a configuration file
does not change isorts outcome.

Remove the caches in `settings.py` completely to re-read the
configuration on each run.

This is safe for the CLI case as we here either use the `Trie`
implementation which collects all known configuration files beforehand,
or we exactly construct one `Config` object based on the first filename,
the working dir, or the explicit `settings_path|file` settings.

Not caching is therefore more efficient for the CLI case and more
useful for the editor case.
    @kaste
    kaste committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    35baed2 View commit details
    Browse the repository at this point in the history

  2. Fix type of _get_config_data

    @kaste
    kaste committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    924466e View commit details
    Browse the repository at this point in the history