Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding logging.config.listen() plugin with examples #874

Merged
merged 5 commits into from
Apr 2, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
56 changes: 56 additions & 0 deletions bandit/plugins/logging_config_insecure_listen.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
# Copyright (c) 2022 Rajesh Pangare
#
# SPDX-License-Identifier: Apache-2.0

r"""
====================================================
B612: Test for insecure use of logging.config.listen
====================================================

This plugin test checks for the unsafe usage of the
``logging.config.listen`` function. The logging.config.listen
function provides the ability to listen for external
configuration files on a socket server. Because portions of the
configuration are passed through eval(), use of this function
may open its users to a security risk. While the function only
binds to a socket on localhost, and so does not accept connections
from remote machines, there are scenarios where untrusted code
could be run under the account of the process which calls listen().

logging.config.listen provides the ability to verify bytes received
across the socket with signature verification or encryption/decryption.

:Example:
>> Issue: [B612:logging_config_listen] Use of insecure
logging.config.listen detected.
Severity: Medium Confidence: High
CWE: CWE-94 (https://cwe.mitre.org/data/definitions/94.html)
Location: examples/logging_config_insecure_listen.py:3:4
2
3 t = logging.config.listen(9999)

.. seealso::

- https://docs.python.org/3/library/logging.config.html#logging.config.listen

.. versionadded:: 1.7.5

raj3shp marked this conversation as resolved.
Show resolved Hide resolved
"""

import bandit
from bandit.core import issue, test_properties as test


@test.checks('Call')
@test.test_id('B612')
def logging_config_insecure_listen(context):
if (
context.call_function_name_qual == 'logging.config.listen'
and 'verify' not in context.call_keywords
):
return bandit.Issue(
raj3shp marked this conversation as resolved.
Show resolved Hide resolved
severity=bandit.MEDIUM,
confidence=bandit.HIGH,
cwe=issue.Cwe.CODE_INJECTION,
text="Use of insecure logging.config.listen detected."
)
5 changes: 5 additions & 0 deletions doc/source/plugins/b612_logging_config_insecure_listen.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---------------
B102: exec_used
---------------

.. automodule:: bandit.plugins.logging_config_insecure_listen
3 changes: 3 additions & 0 deletions examples/logging_config_insecure_listen.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import logging.config

t = logging.config.listen(9999)
3 changes: 3 additions & 0 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,9 @@ bandit.plugins =
snmp_insecure_version = bandit.plugins.snmp_security_check:snmp_insecure_version_check
snmp_weak_cryptography = bandit.plugins.snmp_security_check:snmp_crypto_check

# bandit/plugins/logging_config_insecure_listen.py
logging_config_insecure_listen = bandit.plugins.logging_config_insecure_listen:logging_config_insecure_listen

[build_sphinx]
all_files = 1
build-dir = doc/build
Expand Down