Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request for feedback via 馃憤 #871

Merged
merged 1 commit into from Apr 2, 2022
Merged

Add request for feedback via 馃憤 #871

merged 1 commit into from Apr 2, 2022

Conversation

ericwb
Copy link
Member

@ericwb ericwb commented Apr 1, 2022

This change encourages users to give a 馃憤 if they really like a particular feature.

This change encourages users to give a 馃憤 if they really like a particular feature.
Copy link
Member

@sigmavirus24 sigmavirus24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly there's no way to sort by reactions. I'm not sure this will be easy to do or fulfill the promise

@ericwb
Copy link
Member Author

ericwb commented Apr 2, 2022

Sadly there's no way to sort by reactions. I'm not sure this will be easy to do or fulfill the promise

Believe or not, there is a way to filter by reactions: https://docs.github.com/en/search-github/searching-on-github/searching-issues-and-pull-requests#search-by-number-of-reactions

Copy link
Member

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea卤

@ericwb ericwb merged commit b177a3e into main Apr 2, 2022
@ericwb ericwb deleted the ericwb-patch-1 branch April 2, 2022 14:45
@sigmavirus24
Copy link
Member

Believe or not, there is a way to filter by reactions: https://docs.github.com/en/search-github/searching-on-github/searching-issues-and-pull-requests#search-by-number-of-reactions

That's sorting by total quantity, not number of 馃憤. So any reaction counts towards that including 馃憥

@ericwb
Copy link
Member Author

ericwb commented Apr 2, 2022

Believe or not, there is a way to filter by reactions: https://docs.github.com/en/search-github/searching-on-github/searching-issues-and-pull-requests#search-by-number-of-reactions

That's sorting by total quantity, not number of 馃憤. So any reaction counts towards that including 馃憥

Good point. Would you prefer I revert the PR?

@sigmavirus24
Copy link
Member

I just want to be clear that this will be a manual process of sorting and then checking the reactions manually which may make this more onerous for us and thus break expectations for users who are trying to vote as we indicate. I think we should try it out, but I don't have high expectations for success personally.

GitHub isn't designed for us as Open Source projects - it's designed and built almost exclusively for corporate users at this point. This is why moderation tools are crap. It's why pull request reviews are prime vectors for spam. It's why trying to manage feature requests doesn't work. I almost wonder if discussions are a better venue for feature requests than issues, even though they're completely a separate flow and notifications seem unreliable there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants