Fix line range using Python 3.8 end_lineno #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericwb
requested review from
lukehinds,
ghugo and
sigmavirus24
as code owners
Python 3.8 and above have new ast node attributes to identify the end line number and end column offset [1]. Python 3.8 also fixes line numbers for multiline strings [2]. This fixes the issue mentioned in #820, but only for Python 3.8+. [1] https://docs.python.org/3.8/library/ast.html#ast.AST.end_lineno [2] https://bugs.python.org/issue31241 Signed-off-by: Eric Brown <browne@vmware.com>
lukehinds
approved these changes
Mar 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.8 and above have new ast node attributes to identify the
end line number and end column offset [1].
Python 3.8 also fixes line numbers for multiline strings [2].
This fixes the issue mentioned in #820, but only for Python 3.8+.
[1] https://docs.python.org/3.8/library/ast.html#ast.AST.end_lineno
[2] https://bugs.python.org/issue31241
Signed-off-by: Eric Brown browne@vmware.com