Blacklist pandas read_pickle and add functional test for it #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaspersival
requested review from
ericwb,
ghugo,
lukehinds and
sigmavirus24
as code owners
|
One thing to note, I cannot get Tox to work locally for this repo, so I hope that running it here in the pipeline gives feedback whether it actually works as expected. |
ericwb
requested changes
Feb 8, 2022
test-requirements.txt
Outdated
| @@ -9,3 +9,4 @@ testscenarios>=0.5.0 # Apache-2.0/BSD | |||
| testtools>=2.3.0 # MIT | |||
| beautifulsoup4>=4.8.0 # MIT | |||
| pylint==1.9.4 # GPLv2 | |||
| pandas==1.2.4 | |||
There was a problem hiding this comment.
This isn't necessary as the python example is not actually compiled or run. We only run the AST parser on it to detect security issues.
ericwb
reviewed
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pandas read pickle method uses pickle.load under the hood. When read_pickle is used, bandit will however not find this vulnerability during the scan. This PR solves this by adding the pandas read_pickle method to the blacklist.