Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated titles for plugins b109 and b111 to fix #367 #372

Closed
wants to merge 4 commits into from

Conversation

jaherne
Copy link

@jaherne jaherne commented Aug 17, 2018

Updated the titles for plugins B109 and B111 to match the titles used for the other plugins. This resolves #367.

Copy link
Member

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this fixes the listing in the index, but not when clicking on the document for the actual plugin. This is all occuring because other plugins are auto-doc'd from the code whereas these two were hardcoded because the plugins were removed.

We need a solution that shows the plugin names in the index listing and the plugin titles when browsing the page.

@jaherne
Copy link
Author

jaherne commented Sep 4, 2018

Thanks for the review. Attached is a screenshot of B109 after I hardcoded plugin titles. Is this the desired view?

screen shot 2018-09-04 at 3 24 10 pm

@ericwb
Copy link
Member

ericwb commented Apr 1, 2022

Fixed with #864

@ericwb ericwb closed this Apr 1, 2022
@jaherne jaherne deleted the docfix branch April 30, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs plugin listing shows title instead of check name
2 participants