language and linting updates #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marksmayo
commented
Apr 4, 2023
marksmayo
commented
- converted several format strings to f-strings
- sorted and tidied imports (isort)
- cleaned some whitespace
- updated pylintrc to exclude examples
- updated pylintrc to specify all currently failing cases, so any new ones could be part of pre-commit if so wished
- converted several format strings to f-strings - sorted and tidied imports (isort) - cleaned some whitespace - updated pylintrc to exclude examples - updated pylintrc to specify all currently failing cases, so any new ones could be part of pre-commit if so wished
marksmayo
requested review from
ericwb,
lukehinds and
sigmavirus24
as code owners
ericwb
requested changes
Apr 4, 2023
match pep8 for imports
ericwb
reviewed
Apr 6, 2023
stylistic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.