Prune API surface from PIconButtonMenu #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This reverts commit dd2e332.
pleek91
reviewed
May 2, 2024
| icon?: Icon, | ||
| placement?: PositionMethod | PositionMethod[], | ||
| preventCloseOnClick?: boolean, |
There was a problem hiding this comment.
Dang, I remember this being added and it making me sad. Happy to see it removed!
pleek91
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIconButtonMenu exposes placement and closeOnClick but nowhere in the 36 components that use PIconButtonMenuare are these used.
I'm removing this API surface until we have a genuine use for it, to make migration to Radix marginally easier.