Radix PCard #1257
Merged
Radix PCard #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Merged
pleek91
reviewed
Apr 30, 2024
src/components/Card/PCardContent.vue
Outdated
There was a problem hiding this comment.
This applies to most of these. Why is this a component and not just part of the PCard component? This is basically just an abstraction of a div and a class.
|
The accordion looks nice and the keyboard support ❤️ |
|
Changed the base of the branch so the changes would diff against PAccordion and not main |
pleek91
approved these changes
May 1, 2024
|
I feel like this branch needs rebased on main or something. Diff is weird considering the accordion changes were merged into main already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Radix PCard components, exchanges flat prop for "ghost" variant.