Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: survey previews should never have the submit button disabled #1650

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

lucasheriques
Copy link
Contributor

@lucasheriques lucasheriques commented Jan 14, 2025

Changes

Closes PostHog/posthog#27499

to prevent this from happening:

CleanShot 2025-01-14 at 15 03 13@2x

also add a Surveys link to our Nextjs playground header

...

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

Sorry, something went wrong.

Unverified

No user is associated with the committer email.
Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Jan 14, 2025 6:07pm

Copy link

Size Change: +32 B (0%)

Total Size: 3.23 MB

Filename Size Change
dist/all-external-dependencies.js 207 kB +4 B (0%)
dist/array.full.es5.js 264 kB +4 B (0%)
dist/array.full.js 366 kB +4 B (0%)
dist/array.full.no-external.js 365 kB +4 B (0%)
dist/module.full.js 366 kB +4 B (0%)
dist/module.full.no-external.js 365 kB +4 B (0%)
dist/surveys-preview.js 58.1 kB +4 B (+0.01%)
dist/surveys.js 63.8 kB +4 B (+0.01%)
ℹ️ View Unchanged
Filename Size
dist/array.js 180 kB
dist/array.no-external.js 179 kB
dist/customizations.full.js 12.6 kB
dist/dead-clicks-autocapture.js 14.4 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.64 kB
dist/main.js 181 kB
dist/module.js 180 kB
dist/module.no-external.js 179 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/tracing-headers.js 1.76 kB
dist/web-vitals.js 10.4 kB

compressed-size-action

@lucasheriques lucasheriques added the bump patch Bump patch version when this PR gets merged label Jan 14, 2025
@lucasheriques lucasheriques merged commit dd1cc7a into main Jan 14, 2025
36 checks passed
@lucasheriques lucasheriques deleted the fix/previews-are-never-disabled branch January 14, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Survey templates render buttons differently
2 participants