-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Deprecate sanitize_properties
#1632
feat: Deprecate sanitize_properties
#1632
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
We can achieve the exact same outcome we achieve with `sanitize_properties` by using `before_send` which is a much more compreheensive function, with better usability and ergonomics. We can't remove this function without a major, so let's deprecate it and issue a console warning when it's used.
8d54002
to
6bd0137
Compare
Size Change: +1.41 kB (+0.04%) Total Size: 3.22 MB
ℹ️ View Unchanged
|
We're deprecating `sanitize_properties` on PostHog/posthog-js#1632, so let's suggest using `before_send` everywhere where we previously suggested `sanitize_properties`
Website update to suggest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, this is even better since sanitize_properties
is called on properties and $set_once but not on $set
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Changes
We can achieve the exact same outcome we achieve with
sanitize_properties
by usingbefore_send
which is a much more compreheensive function, with better usability and ergonomics.We can't remove this function without a major, so let's deprecate it and issue a console warning when it's used.
Checklist