Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore original makefiles and not use buildx #35

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

DoumanAsh
Copy link
Collaborator

@DoumanAsh DoumanAsh commented Apr 17, 2023

I didn't notice when from buildx came originally but it seems @zs-dima introduced it for regular x86 build, even though it didn't work properly in CI.
So I think it is good to restore it back as it was since @zs-dima introduced new workflow for arm
I'm not sure though why docker buildx doesn't work properly, but I'm unfortunately on windows so I do not have ability to test it locally

@DoumanAsh
Copy link
Collaborator Author

@zs-dima
Copy link
Contributor

zs-dima commented Apr 17, 2023

@DoumanAsh could I kindly ask you to describe obstacles you have with the buildx ?

@DoumanAsh
Copy link
Collaborator Author

DoumanAsh commented Apr 17, 2023

@zs-dima Once you setup buildx it fails:
https://github.com/PlugFox/docker_flutter/actions/runs/4716295768/jobs/8363893795

[linux/arm/v7 build 2/6] RUN set -eux; mkdir -p /usr/lib /tmp/glibc /var/tmp/.pub_cache && apk --no-cache add bash curl git ca-certificates wget unzip && rm -rf /var/lib/apt/lists/* /var/cache/apk/*:
#0 0.102 exec /bin/sh: exec format error

I'm not sure why though, and I don't have ability to figure it out.
So it would be better to restore github action to work with x86 at least instead of having it broken due to buildx

If you know how to fix it please let me know.
I rely on these images and would like it to be always working for at least x86

@zs-dima
Copy link
Contributor

zs-dima commented Apr 17, 2023

@DoumanAsh ARM is not supposed by GitHub currently out of the box, let's disable ARM for now.

@DoumanAsh
Copy link
Collaborator Author

@zs-dima You can try if you can, aarch64 doesn't work itself too
https://github.com/PlugFox/docker_flutter/actions/runs/4717317043/jobs/8365812277
If we're just building x86, there is no need for buildx

@zs-dima
Copy link
Contributor

zs-dima commented Apr 17, 2023

@DoumanAsh even simpler - just remove ARM option from the buildx configuration

@zs-dima
Copy link
Contributor

zs-dima commented Apr 17, 2023

@DoumanAsh
Blocker issue to build for ARM: flutter/flutter#73260
Some more related issues:
dart-lang/sdk#51642
actions/runner-images#5631

  • upvotes are welcome

@DoumanAsh
Copy link
Collaborator Author

If we remove all arm* variants, there is no point in using buildx
once they fix it, you can add it to this build configuration

@zs-dima
Copy link
Contributor

zs-dima commented Apr 17, 2023

@DoumanAsh it is point to use buildx as you could back arm easily after this issue is closed, although I do not mind to remove buildx for now.
Any way buildx doesn't introduce any issue.

@DoumanAsh
Copy link
Collaborator Author

Please do not make changes without making sure it would work next time.
I know @PlugFox doesn't have time to check every PR, so I would prefer everyone with write access to this repo to be careful when they break something
Using buildx just because you prefer it for no gain is not something worth breaking CI over

@DoumanAsh DoumanAsh merged commit 374c76d into master Apr 17, 2023
2 checks passed
@DoumanAsh DoumanAsh deleted the restore_old_x86_build branch April 17, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants