New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pass job_tags and session_id kwargs correctly #358
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #358 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 322 322
=========================================
Hits 322 322 ☔ View full report in Codecov by Sentry. |
[sc-52032] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't matter too much but is it possible to add testing for this?
Maybe if I try hard enough, but it looks like currently we don't test that kwargs work in the tests, just that passing them to the device doesn't cause the circuit to fail, so it would be a bit unprecedented. I tried getting the information from Here's a screenshot where you can see that my tag ("now with a session") and session id were registered when the task ran. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking! Looks good. Here's a 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
A user on the forum was trying to pass
job_tags
andsession_id
to thecircuit_runner
device, unsuccessfully.They were being included in generic runtime kwargs and passed to the runtime service in the
program_inputs
argument, which doesn't work;job_tags
belongs in theoptions
dictionary, andsession_id
is its own kwarg onruntime_service.run
. Now they will be passed to the correct places.