Skip to content
This repository was archived by the owner on Aug 17, 2024. It is now read-only.

Adding ical-output support #49

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Conversation

migmedia
Copy link
Contributor

@migmedia migmedia commented Dec 1, 2021

Feature: generator emits calendar-elements: tested with o365 and sabre.
Builder-macro for IcalEvent, IcalCalendar and VcardContact.

Builder-macro for IcalEvent, IcalCalendar and VcardContact.
@dcormier
Copy link
Contributor

dcormier commented Feb 1, 2023

It would be nice to see support for writing ical.

@Peltoche
Copy link
Owner

Peltoche commented Feb 2, 2023

Hi @migmedia 👋

Thanks a lot for this PR, this is some great stuff! I finish to take a look and if everything is ok (it should be) I should merge today.

@Peltoche
Copy link
Owner

Peltoche commented Feb 2, 2023

If you have the time, there is a linter error for a useless casting but this is not blocking.

Copy link
Owner

@Peltoche Peltoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peltoche
Copy link
Owner

Peltoche commented Feb 2, 2023

Damn! December 2021!! 😱 . I'm kind of late! Sorry for the delay...

@Peltoche Peltoche merged commit f82bbf4 into Peltoche:master Feb 2, 2023
@migmedia migmedia deleted the IcalEmitter branch February 2, 2023 09:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants