This repository was archived by the owner on Aug 17, 2024. It is now read-only.
Ical serde #44
Merged
Ical serde #44
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Peltoche . Sorry for the spam, I've written #43 (comment) but I'm not sure whether closed issues or MR will trigger a notification for you :-/ When are you considering releasing a new version of ical? I'd like to publish a crate that depends on yours (including my commit), but I cannot do so in case a dependency of mine is not published either :-( Thanks :) |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for your work on iCalendar files!
On a project of mine, I'd like to store a
Vec<Property>in a struct that can be serialized/deserialized byserde...but this fails becausePropertydoes not supportserdeitself.This PR is adding serde support, to
Propertybut also to every struct where (I think) it makes sense.In case you accept it, I'd be glad you released a 0.8.0 with this change, it would help my downstream project :D )