-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement diesel compatibility #318
Conversation
Thank you for the PR! I'm going to release |
Overall this looks good to me, what do you think about moving Also thanks to @NobodyXu for giving this a once over! |
tests/diesel/src/lib.rs
Outdated
// create and open a temporary database | ||
let tempdir = tempdir()?; | ||
let db_path = tempdir.path().join("compact_str.sqlite3"); | ||
let db_path = format_compact!("file://{}", db_path.to_str().unwrap()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the use of the macro!
This PR allows using CompactString as representation for [diesel](https://diesel.rs/) text columns.
I was not sure if how I am using diesel is best practice, and didn't want to call it an example because of that. But I guess it does not matter all that much. :) I move the code into |
Fantastic, thanks @Kijewski! |
This PR allows using CompactString as representation for diesel text columns.