-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse createAnyOneOf
while creating a property
#628
Conversation
🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌 |
@Ugzuzg, thanks for opening the PR. Looks like there was a linter error that stopped the build from happening. |
ea67e0f
to
59a6b2a
Compare
@sserrata, reconfigured eslint to allow importing dev dependencies in test files. Hope, that's ok. |
59a6b2a
to
e056dc8
Compare
`createAnyOneOfProperty` has an incomplete implementation and doesn't display all possible types at the moment, but only 'object' type.
e056dc8
to
79ca6c4
Compare
Visit the preview URL for this PR (updated for commit 79ca6c4): https://docusaurus-openapi-36b86--pr628-gy4p38hx.web.app (expires Thu, 16 Nov 2023 15:39:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Hi @Ugzuzg, I addressed the remaining linter error. The deploy preview looks good - how are things looking for you? |
Looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested with CSPM Reports API spec
🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️ |
Description
createAnyOneOfProperty
has an incomplete implementation and doesn't display all possible types at the moment, but only 'object' type. ReusingcreateAnyOneOf
helps with making it display all possible mods.Motivation and Context
A bug in
createAnyOneOfProperty
prevents from seeing all mods and showsMOD1
,MOD2
, etc for primitive types and arrays.How Has This Been Tested?
See the snapshot of the before and after:
55a2685
Screenshots (if appropriate)
Types of changes
Checklist