Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(portal): 用户提交作业时,新增保留作业脚本的选项 #1255

Merged
merged 8 commits into from
May 21, 2024

Conversation

usaveh
Copy link
Contributor

@usaveh usaveh commented May 16, 2024

做了什么:
1.用户提交作业时,新增保留作业脚本的选项
image
此选项为可选项,当用户不填任何值时,将不会保留用户提交的脚本。
当用户不填任何值时,对话框变为warning状态,并有文字提示:
image

对比改动之前:
image

2.保存的脚本:
image

Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: 21d00ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@scow/grpc-api Minor
@scow/portal-server Patch
@scow/portal-web Patch
@scow/demo-vagrant Patch
@scow/ai Patch
@scow/protos Patch
@scow/lib-hook Patch
@scow/lib-operation-log Patch
@scow/lib-scheduler-adapter Patch
@scow/lib-server Patch
@scow/audit-server Patch
@scow/mis-server Patch
@scow/mis-web Patch
@scow/auth Patch
@scow/gateway Patch
@scow/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkuhpc-review-bot pkuhpc-review-bot bot added the Code-ReviewRequested Code Review Requested label May 16, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot requested a review from ddadaal May 16, 2024 08:40
Copy link
Member

@ddadaal ddadaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI改一下,当用户清空了路径这个框的时候,给这个框加一个warning的validation,提示用户此次提交的脚本将不会被保存

@pkuhpc-review-bot pkuhpc-review-bot bot added Code-ChangeRequested and removed Code-ReviewRequested Code Review Requested labels May 16, 2024
@usaveh usaveh added Code-ReviewRequested Code Review Requested and removed Code-ChangeRequested labels May 17, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot requested a review from ddadaal May 17, 2024 07:33
@usaveh
Copy link
Contributor Author

usaveh commented May 17, 2024

UI改一下,当用户清空了路径这个框的时候,给这个框加一个warning的validation,提示用户此次提交的脚本将不会被保存

okk

@pkuhpc-review-bot pkuhpc-review-bot bot added Code-ChangeRequested and removed Code-ReviewRequested Code Review Requested labels May 18, 2024
@usaveh usaveh added Code-ReviewRequested Code Review Requested and removed Code-ChangeRequested labels May 21, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot requested a review from ddadaal May 21, 2024 09:23
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-Approved Code Review approved ReadyForMerge Ready for merge and removed Code-ReviewRequested Code Review Requested labels May 21, 2024
@ddadaal ddadaal merged commit 6304074 into master May 21, 2024
9 checks passed
@ddadaal ddadaal deleted the feat-portal-save-script branch May 21, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code-Approved Code Review approved ReadyForMerge Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants