Generic/ConstructorName: more defensive coding / prevent fatal error #814
+44
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigoprimo
approved these changes
Feb 17, 2025
src/Standards/Generic/Tests/NamingConventions/ConstructorNameUnitTest.3.inc
Outdated
Show resolved
Hide resolved
... to allow for adding additional test case files for parse error tests.
This sniff could throw the following fatal errors when it encountered parse errors/during live coding: ``` Fatal error: Uncaught PHP_CodeSniffer\Exceptions\RuntimeException: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in path/to/PHPCS/src/Standards/Generic/Sniffs/NamingConventions/ConstructorNameSniff.php on line 83 in path/to/PHPCS/src/Runner.php on line 624 Fatal error: Uncaught PHP_CodeSniffer\Exceptions\RuntimeException: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in path/to/PHPCS/src/Standards/Generic/Sniffs/NamingConventions/ConstructorNameSniff.php on line 167 in path/to/PHPCS/src/Runner.php on line 624 ``` Fixed now by adding more defensive coding. Includes test safeguarding the fix.
jrfnl
force-pushed
the
feature/generic-constructorname-more-defensive-coding
branch
from
f7e0548 to
3a76062
Compare
jrfnl
deleted the
feature/generic-constructorname-more-defensive-coding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generic/ConstructorName: rename test case file
... to allow for adding additional test case files for parse error tests.
Generic/ConstructorName: more defensive coding
This sniff could throw the following fatal errors when it encountered parse errors/during live coding:
Fixed now by adding more defensive coding.
Includes tests safeguarding the fix.
Suggested changelog entry
Generic.NamingConventions.ConstructorName: prevent potential fatal errors during live coding
Types of changes