Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct pluralization of the word space/spaces depending on the spacing value #128

Merged
merged 4 commits into from Dec 8, 2023
Merged

Correct pluralization of the word space/spaces depending on the spacing value #128

merged 4 commits into from Dec 8, 2023

Commits on Dec 8, 2023

  1. Various sniffs: fix grammar for various error messages 

    Correct pluralization of the word space/spaces depending on the spacing value.

For these sniffs, the changes are already covered by pre-existing tests.

Port squizlabs/PHP_CodeSniffer 3881 to this repo
    @DannyvdSluijs @jrfnl
    DannyvdSluijs authored and jrfnl committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    d46210e View commit details
    Browse the repository at this point in the history

  2. Generic/ArrayIndent: fix grammar for various error messages 

    Correct pluralization of the word space/spaces depending on the spacing value.

Includes adding tests for the `$indent` property being set to a 1 (open brace) and 0 (item indent, close brace).

Co-authored-by: Danny van der Sluijs <danny.van.der.sluijs@infi.nl>
    @jrfnl @DannyvdSluijs
    jrfnl and DannyvdSluijs committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    4cf6bad View commit details
    Browse the repository at this point in the history

  3. Squiz/ArrayDeclaration: fix grammar for various error messages 

    Correct pluralization of the word space/spaces depending on the spacing value.

Includes adding tests for the `CloseBraceNotAligned` error code which would use the "1 space" phrasing.

Co-authored-by: Danny van der Sluijs <danny.van.der.sluijs@infi.nl>
    @jrfnl @DannyvdSluijs
    jrfnl and DannyvdSluijs committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    d785815 View commit details
    Browse the repository at this point in the history

  4. Squiz/ControlSignature: fix grammar for various error messages 

    Correct pluralization of the word space/spaces depending on the spacing value.

Includes adding tests for the `$requiredSpacesBeforeColon` property being set to a > 1 value.

Co-authored-by: Danny van der Sluijs <danny.van.der.sluijs@infi.nl>
    @jrfnl @DannyvdSluijs
    jrfnl and DannyvdSluijs committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    5632363 View commit details
    Browse the repository at this point in the history