Skip to content

CI: ParaUnit not used under MacOS #8528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2025
Merged

Conversation

keradus
Copy link
Member

@keradus keradus commented Mar 22, 2025

if anyone knows how to prevent ParaUnit to fail under CI, I'm happy to keep using it.
I failed to reproduce issue locally, but we see it in each PR.

keradus added 2 commits March 22, 2025 13:33
@coveralls
Copy link

Coverage Status

coverage: 94.876% (+0.01%) from 94.866%
when pulling 7504ab8 on keradus:macos
into 538f675 on PHP-CS-Fixer:master.

@keradus keradus marked this pull request as ready for review March 22, 2025 12:39
@keradus keradus enabled auto-merge (squash) March 22, 2025 12:39
@keradus keradus changed the title CI: try MacOS job without ParaUnit CI: ParaUnit not used under MacOS Mar 22, 2025
Copy link
Contributor

@kubawerlos kubawerlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I looking somewhere wrong or is the change making the macOS tests run only 2 seconds slower?

37 seconds on this branch: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/actions/runs/14008587504/job/39225564475
35 seconds latest run on master: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/actions/runs/13994451925/job/39227985363

@keradus keradus merged commit 89a4e48 into PHP-CS-Fixer:master Mar 22, 2025
30 checks passed
@keradus
Copy link
Member Author

keradus commented Mar 22, 2025

i do not see big diff too.
yet, I see diff on linux builds.

i assumed the diff is due to subset of tests are are running only on linux, but I was not validating deeper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants