Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: MethodArgumentSpaceFixer - handle when nested in HTML #8503

Merged
merged 2 commits into from
Mar 13, 2025
Merged

fix: MethodArgumentSpaceFixer - handle when nested in HTML #8503

merged 2 commits into from
Mar 13, 2025
+34 −1

Conversation

kubawerlos
Copy link
Contributor

Fixes #8502

Please, notice that the failures before the fix are:

Code built on expected code must not change.

and

Expected no changes made to test "Integration of fixers: method_argument_space,statement_indentation. "--EXPECT-- part run"" in "misc/method_argument_space,statement_indentation.test".

@kubawerlos
Add tests
Loading
Loading status checks…
c2266f9
@kubawerlos
Add fix

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
1ec40b1
@kubawerlos kubawerlos force-pushed the fix_MethodArgumentSpaceFixer branch from e808ab0 to 1ec40b1 Compare March 13, 2025 16:13
@coveralls
Copy link

Coverage Status

coverage: 94.845% (+0.3%) from 94.502%
when pulling 1ec40b1 on 6b7562617765726c6f73:fix_MethodArgumentSpaceFixer
into 2b85ed7 on PHP-CS-Fixer:master.

keradus
keradus reviewed Mar 13, 2025
View reviewed changes
Copy link
Member

@keradus keradus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall OKish to merge as change is minimal, but I do not want to support any mixed PHP/HTML code.

@keradus keradus merged commit e28458b into PHP-CS-Fixer:master Mar 13, 2025
29 checks passed
@keradus keradus deleted the fix_MethodArgumentSpaceFixer branch March 13, 2025 18:11
@kubawerlos
Copy link
Contributor Author

I do not want to support any mixed PHP/HTML code.

Me neither, but the tool does, at least in v3.

@keradus
Copy link
Member

keradus commented Mar 13, 2025

but we may still not prioritise any work on it

@kubawerlos
Copy link
Contributor Author

Bugfixes, PHP 8.4 support and PER-CS all have higher priority on my list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

method_argument_space and statement_indentation keep adding more spaces to html file with inline php
3 participants
@kubawerlos @coveralls @keradus