Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert ref for self-approval Git checkout #7944

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

Wirone
Copy link
Member

@Wirone Wirone commented Apr 15, 2024

Partially reverts #7936

It does not work, because it tries to check out branch which is not present in the repository. I'll fiddle with it in my fork and will come back with verified solution. Sorry for the trouble.

It does not work, because it tries to check out branch which is not present in the repository.
@Wirone Wirone self-assigned this Apr 15, 2024
@Wirone Wirone requested a review from keradus as a code owner April 15, 2024 07:58
@coveralls
Copy link

Coverage Status

coverage: 96.013%. remained the same
when pulling 0dcb6f9 on Wirone:codito/revert-self-approval-ref
into 54f8878 on PHP-CS-Fixer:master.

@keradus
Copy link
Member

keradus commented Apr 15, 2024

I'll fiddle with it in my fork

I remember suggesting it on very start ;)

but overall, maybe it's simply OK to have this auto-approval on 2nd push, that includes only that single commit? not sure if deep dive into in deeper is worth it

@keradus keradus merged commit 7ec3c31 into PHP-CS-Fixer:master Apr 15, 2024
27 of 28 checks passed
@Wirone Wirone deleted the codito/revert-self-approval-ref branch April 15, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants