Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Ignore PHP version related mutations #7935

Merged
merged 2 commits into from
Apr 11, 2024
Merged

test: Ignore PHP version related mutations #7935

merged 2 commits into from
Apr 11, 2024

Conversation

Wirone
Copy link
Member

@Wirone Wirone commented Apr 11, 2024 •
edited

Discussed with @maks-rafalko, it does not make sense to mutate code related to PHP versions, as it will always produce escape mutants, because these conditions are there for a reason 馃槈.

Tested locally with:

composer infection -- --filter=src/Fixer/Alias/MbStrFunctionsFixer.php --map-source-class-to-test
composer infection -- --filter=src/Fixer/Basic/OctalNotationFixer.php --map-source-class-to-test

Code containing VersionSpecification or PHP_VERSION_ID is not mutated.

@Wirone Wirone self-assigned this Apr 11, 2024
@coveralls
Copy link

coveralls commented Apr 11, 2024 •
edited

Coverage Status

coverage: 96.013%. remained the same
when pulling e682463 on Wirone:codito/infection-ignore-rules
into 64567d1 on PHP-CS-Fixer:master.

maks-rafalko
maks-rafalko approved these changes Apr 11, 2024
View reviewed changes
Copy link

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@Wirone Wirone force-pushed the codito/infection-ignore-rules branch from 2f00f54 to cc3daf1 Compare April 11, 2024 11:12
@Wirone Wirone enabled auto-merge (squash) April 11, 2024 11:16
@Wirone Wirone merged commit 75168ee into PHP-CS-Fixer:master Apr 11, 2024
27 checks passed
@Wirone Wirone deleted the codito/infection-ignore-rules branch April 11, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maks-rafalko maks-rafalko maks-rafalko approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees

@Wirone Wirone

Labels
topic/tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Wirone @coveralls @maks-rafalko