Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add array_indentation to PER-CS2.0 ruleset #7881

Merged
merged 3 commits into from Mar 14, 2024
Merged

feat: Add array_indentation to PER-CS2.0 ruleset #7881

merged 3 commits into from Mar 14, 2024

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Mar 12, 2024 •
edited

See https://www.php-fig.org/per/coding-style/#11-arrays

Array declarations MAY be split across multiple lines, where each subsequent line is indented once.

Closes #7846

@VincentLanglet VincentLanglet mentioned this pull request Mar 12, 2024
Closed
@coveralls
Copy link

coveralls commented Mar 12, 2024 •
edited

Coverage Status

coverage: 96.034%. remained the same
when pulling da5d1bd on VincentLanglet:arrayIndentation
into 32866fc on PHP-CS-Fixer:master.

julienfalque
julienfalque reviewed Mar 13, 2024
View reviewed changes
Copy link
Member

@julienfalque julienfalque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks! 😄

Please update tests in tests/Fixtures/Integration/set/

@Wirone Wirone changed the title feat: Add array_indentation to PERCS2 feat: Add array_indentation to PER-CS2.0 Mar 14, 2024
@Wirone Wirone changed the title feat: Add array_indentation to PER-CS2.0 feat: Add array_indentation to PER-CS2.0 ruleset Mar 14, 2024
@Wirone Wirone enabled auto-merge (squash) March 14, 2024 07:11
@Wirone Wirone merged commit 5cfa1f9 into PHP-CS-Fixer:master Mar 14, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus keradus left review comments

@Wirone Wirone Wirone approved these changes

@julienfalque julienfalque julienfalque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@VincentLanglet @coveralls @Wirone @julienfalque @keradus