Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PhpUnitTestClassRequiresCoversFixer - do not add annotation when there are attributes #7880

Conversation

kubawerlos
Copy link
Contributor

Fixes #7878

@kubawerlos kubawerlos force-pushed the fix_PhpUnitTestClassRequiresCoversFixer branch from 2f647e2 to 4cb7125 Compare March 12, 2024 20:37
@coveralls
Copy link

coveralls commented Mar 12, 2024

Coverage Status

coverage: 96.052% (+0.004%) from 96.048%
when pulling 770e294 on 6b7562617765726c6f73:fix_PhpUnitTestClassRequiresCoversFixer
into 6a69160 on PHP-CS-Fixer:master.

@kubawerlos kubawerlos force-pushed the fix_PhpUnitTestClassRequiresCoversFixer branch from 91a4118 to 9b6a992 Compare March 13, 2024 06:55
Wirone
Wirone previously requested changes Mar 25, 2024
Copy link
Member

@Wirone Wirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional doubts 😊.

src/Fixer/AbstractPhpUnitFixer.php Outdated Show resolved Hide resolved
src/Fixer/AbstractPhpUnitFixer.php Outdated Show resolved Hide resolved
@kubawerlos kubawerlos force-pushed the fix_PhpUnitTestClassRequiresCoversFixer branch from 838c6c5 to fb915ed Compare April 8, 2024 14:47
@kubawerlos kubawerlos enabled auto-merge (squash) April 15, 2024 15:06
@Wirone Wirone dismissed their stale review April 15, 2024 16:44

Concerns addressed already - unblocking

@kubawerlos kubawerlos merged commit 8a115cd into PHP-CS-Fixer:master Apr 15, 2024
27 checks passed
@kubawerlos kubawerlos deleted the fix_PhpUnitTestClassRequiresCoversFixer branch April 15, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

php_unit_test_class_requires_covers does not understand PHPUnit 10 attributes
5 participants