fix: Correctly indent multiline constants and properties #7875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wirone
approved these changes
Mar 11, 2024
| * Returns whether the token at given index is the last token in a property | ||
| * declaration before the type or the name of that property. | ||
| */ | ||
| private function isPropertyStart(Tokens $tokens, int $index): bool |
There was a problem hiding this comment.
This would be more helpful as a commonly-accessible helper method. I believe we have similar thing somewhere else already, and it's getting out of hand 😅. But it's good enough, I don't expect you finding better place for it at this point. I just think, in general, we need more reusable code for token traversing, manipulating etc.
There was a problem hiding this comment.
I agree but in this case the method is quite specific: we want the last token before the type or the property name. This is due to how the fixer is currently implemented and it wouldn't be surprising to see that changed in the future, so I'd keep it here for now.
julienfalque
force-pushed
the
fix-multiline-const-and-properties-indent
branch
from
b2ea810
to
d340ae5
Compare
julienfalque
force-pushed
the
fix-multiline-const-and-properties-indent
branch
from
d340ae5
to
9d1376a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7866 and #6509.