Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update PHPStan #7871

Merged
merged 2 commits into from Mar 9, 2024

Conversation

kubawerlos
Copy link
Contributor

@kubawerlos kubawerlos commented Mar 9, 2024

This will fix failing CI on main branch.

I've fixed all the straightforward issues.

All added entries to baseline are related to preg_* functions - types of $matches and $count - fixing them will need some discussion and time, as we might end up with adding some generic types e.g. https://github.com/phpstan/phpstan-src/blob/1.10.60/stubs/core.stub#L181-L203, so let's do it separately.

@kubawerlos kubawerlos changed the title Update PHPStan chore: update PHPStan Mar 9, 2024
@coveralls
Copy link

coveralls commented Mar 9, 2024

Coverage Status

coverage: 96.029%. remained the same
when pulling 3790f78 on 6b7562617765726c6f73:update_phpstan
into b68c8ba on PHP-CS-Fixer:master.

@kubawerlos kubawerlos marked this pull request as ready for review March 9, 2024 05:57
@Wirone Wirone merged commit 450a834 into PHP-CS-Fixer:master Mar 9, 2024
25 checks passed
@Wirone Wirone deleted the update_phpstan branch March 9, 2024 08:25
@Wirone
Copy link
Member

Wirone commented Mar 9, 2024

Thanks @kubawerlos 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants