fix: Constant invocation detected in DNF types #7869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SharkyKZ
changed the title
|
@SharkyKZ thanks for this contribution, just FYI: you should start with test cases, let them fail in CI and then provide a fix in the other commit. This way it would be easier to verify there was a bug in the first place 🙂. Now I need to checkout this locally and imitate the behaviour without a fix, which blocks immediate merge, as I'm reviewing it from mobile 😅. Will take a look later at some point. |
julienfalque
approved these changes
Mar 10, 2024
Wirone
approved these changes
Mar 11, 2024
Wirone
force-pushed
the
dnf-constant-invocation
branch
from
12a765e
to
6742043
Compare
|
Thanks @SharkyKZ 🍻! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes constant invocation being detected in DNF types.