Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: @Symfony:risky - add no_unreachable_default_argument_value #7863

Merged
merged 2 commits into from Mar 11, 2024
Merged

feat: @Symfony:risky - add no_unreachable_default_argument_value #7863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d300945
`@Symfoy:risky` - add `no_unreachable_default_argument_value`
gharlan Mar 3, 2024
56ec609
Merge branch 'master' into symfony-no_unreachable_default_argument_value
keradus Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion doc/ruleSets/PhpCsFixerRisky.rst
View file
Open in desktop
Expand Up @@ -27,7 +27,6 @@ Rules

``['sets' => ['@all']]``

- `no_unreachable_default_argument_value <./../rules/function_notation/no_unreachable_default_argument_value.rst>`_
- `no_unset_on_property <./../rules/language_construct/no_unset_on_property.rst>`_
- `php_unit_data_provider_name <./../rules/php_unit/php_unit_data_provider_name.rst>`_
- `php_unit_data_provider_return_type <./../rules/php_unit/php_unit_data_provider_return_type.rst>`_
Expand Down
5 changes: 0 additions & 5 deletions doc/ruleSets/SymfonyRisky.rst
View file
Open in desktop
Expand Up @@ -60,8 +60,3 @@ Rules
- `string_length_to_empty <./../rules/string_notation/string_length_to_empty.rst>`_
- `string_line_ending <./../rules/string_notation/string_line_ending.rst>`_
- `ternary_to_elvis_operator <./../rules/operator/ternary_to_elvis_operator.rst>`_

Disabled rules
--------------

- `no_unreachable_default_argument_value <./../rules/function_notation/no_unreachable_default_argument_value.rst>`_
1 change: 1 addition & 0 deletions doc/rules/function_notation/no_unreachable_default_argument_value.rst
View file
Open in desktop
Expand Up @@ -40,6 +40,7 @@ The rule is part of the following rule sets:
- `@PHP80Migration:risky <./../../ruleSets/PHP80MigrationRisky.rst>`_
- `@PSR12:risky <./../../ruleSets/PSR12Risky.rst>`_
- `@PhpCsFixer:risky <./../../ruleSets/PhpCsFixerRisky.rst>`_
- `@Symfony:risky <./../../ruleSets/SymfonyRisky.rst>`_

References
----------
Expand Down
1 change: 0 additions & 1 deletion src/RuleSet/Sets/PhpCsFixerRiskySet.php
View file
Open in desktop
Expand Up @@ -47,7 +47,6 @@ public function getRules(): array
'@all',
],
],
'no_unreachable_default_argument_value' => true,
'no_unset_on_property' => true,
'php_unit_data_provider_name' => true,
'php_unit_data_provider_return_type' => true,
Expand Down
1 change: 0 additions & 1 deletion src/RuleSet/Sets/SymfonyRiskySet.php
View file
Open in desktop
Expand Up @@ -55,7 +55,6 @@ public function getRules(): array
'no_homoglyph_names' => true,
'no_php4_constructor' => true,
'no_unneeded_final_method' => true,
'no_unreachable_default_argument_value' => false,
'no_useless_sprintf' => true,
'non_printable_character' => true,
'ordered_traits' => true,
Expand Down